GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-161262: Fix test_touch_common flake on Emscripten by cmaloney · Pull Request #161464 · python/cpython

Conversation

@cmaloney

@cmaloney cmaloney commented Nov 6, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Under Node, NODEFS takes a new file's mtime from the host kernel but utime(path, None) uses Date.now() written back via fs.utimesSync, which can land a millisecond before the creation time. Take the baseline from utime(path, None) too, so both timestamps come from the same source.

  • Issue: test_pathlib.test_touch_common sometimes fails on Emscripten #161262

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@cmaloney @claude
pythongh-161262: Fix test_touch_common flake on Emscripten
5387f7f 
Under Node, NODEFS takes a new file's mtime from the host kernel but
utime(path, None) uses Date.now() written back via fs.utimesSync, which
can land a millisecond before the creation time.  Take the baseline from
utime(path, None) too, so both timestamps come from the same source.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@cmaloney cmaloney added the skip news label Nov 6, 2026
@cmaloney
cmaloney requested a review from barneygale as a code owner November 6, 2026 07:17
@bedevere-app bedevere-app Bot added awaiting core review tests Tests in the Lib/test dir labels Nov 6, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Nov 6, 2026
test_pathlib.test_touch_common sometimes fails on Emscripten #161262
Open
@StanFromIreland
StanFromIreland requested a review from hoodmane November 6, 2026 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@barneygale barneygale Awaiting requested review from barneygale barneygale is a code owner
@hoodmane hoodmane Awaiting requested review from hoodmane

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@cmaloney
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.