GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-161081: Reject mismatched non-contiguous buffers in PyObject_CopyData by raman118 · Pull Request #161514 · python/cpython

Conversation

@raman118

@raman118 raman118 commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Fixes gh-161081.

PyObject_CopyData() used source-buffer indices for both buffers on its non-contiguous copy path. When their shapes differed, this could write to incorrect offsets or read beyond the source index array. Validate that non-contiguous source and destination buffers have the same dimensions and shape before copying.

Add a regression test using _testbuffer arrays with different shapes. The test failed before this change because the copy returned success; it now raises BufferError.

Tests:

  • PCbuild\\build.bat -d -p x64 -M -q
  • PCbuild\\amd64\\python_d.exe -m test -v -m test_mismatched_shape test_buffer
  • PCbuild\\amd64\\python_d.exe -m test -v test_buffer (98 passed, 2 skipped)
  • PCbuild\\amd64\\python_d.exe Tools\\patchcheck\\patchcheck.py

AI assistance was used to investigate the issue and prepare this change. I reviewed the code and test behavior, including the failing pre-fix regression, before opening this PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@raman118
pythongh-161081: Reject mismatched non-contiguous buffers in PyObject…
fb27e62
…_CopyData
@python-cla-bot

python-cla-bot Bot commented Nov 6, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot added the awaiting review label Nov 6, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Nov 6, 2026
PyObject_CopyData() copies wrong data, and can corrupt memory, when source and destination shapes differ and the source is not contiguous #161081
Open
raman118 added 2 commits November 12, 2026 15:50
@raman118
Merge branch 'main' into pythongh-161081-copydata-shape
65dc847
@raman118
Merge branch 'main' into pythongh-161081-copydata-shape
affb1fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PyObject_CopyData() copies wrong data, and can corrupt memory, when source and destination shapes differ and the source is not contiguous

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@raman118
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.