GeezerVison is showing github.com — gh-161081: Reject mismatched non-contiguous buffers in PyObject_CopyData by raman118 · Pull Request #161514 · python/cpython
Conversation
Fixes gh-161081.
PyObject_CopyData() used source-buffer indices for both buffers on its non-contiguous copy path. When their shapes differed, this could write to incorrect offsets or read beyond the source index array. Validate that non-contiguous source and destination buffers have the same dimensions and shape before copying.
Add a regression test using _testbuffer arrays with different shapes. The test failed before this change because the copy returned success; it now raises BufferError.
Tests:
PCbuild\\build.bat -d -p x64 -M -q
PCbuild\\amd64\\python_d.exe -m test -v -m test_mismatched_shape test_buffer
PCbuild\\amd64\\python_d.exe -m test -v test_buffer (98 passed, 2 skipped)
PCbuild\\amd64\\python_d.exe Tools\\patchcheck\\patchcheck.py
AI assistance was used to investigate the issue and prepare this change. I reviewed the code and test behavior, including the failing pre-fix regression, before opening this PR.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
All commit authors signed the Contributor License Agreement.

|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.