GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-161518: Reject a non-bytes encoder result unless it is the ASCII fast path by harjothkhara · Pull Request #161531 · python/cpython

Conversation

@harjothkhara

@harjothkhara harjothkhara commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

TextIOWrapper.write() skips its "encoder should return a bytes object" check when the encoder returns the very same str it was given. That exemption is only valid for the internal ASCII fast path. A custom encoder that returns its non-ASCII input therefore had the str's internal storage written as bytes: a release build silently writes the wrong bytes, and a debug build aborts on an assertion in _textiowrapper_writeflush.

The check now accepts the same-object result only for ASCII text, so this case raises TypeError like any other encoder that does not return bytes. An encoder that returns the same ASCII str is still accepted, as before.

Added test_encoder_returns_str. It fails on the unfixed code (assertion on a debug build, no error on a release build) and passes with the change. test_io and test_codecs pass on a debug build.

I used AI assistance for this and have reviewed the change.

  • Issue: io: TextIOWrapper silently corrupts output when encoder is a no-op #161518

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@harjothkhara @claude
pythongh-161518: Reject a non-bytes encoder result unless it is the A…
c996607
…SCII fast path

TextIOWrapper.write() accepted any encoder result that was the same
object as its input. That is only safe for ASCII text, so a custom
encoder returning a non-ASCII str wrote corrupt data.

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
@bedevere-app bedevere-app Bot mentioned this pull request Nov 7, 2026
io: TextIOWrapper silently corrupts output when encoder is a no-op #161518
Open
@harjothkhara
harjothkhara marked this pull request as ready for review November 7, 2026 05:46
@harjothkhara
harjothkhara requested a review from cmaloney as a code owner November 7, 2026 05:46
@bedevere-app bedevere-app Bot added the awaiting review label Nov 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmaloney cmaloney Awaiting requested review from cmaloney cmaloney is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@harjothkhara
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.