GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Fix JUMP_BACKWARD JIT warmup counter reset by divya-git03 · Pull Request #161561 · python/cpython

Conversation

divya-git03 commented Nov 7, 2026

Copy link

Copy Markdown

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Fix JUMP_BACKWARD JIT warmup counter reset

52f8e08

divya-git03 requested a review from markshannon as a code owner

November 7, 2026 15:08

python-cla-bot Bot commented Nov 7, 2026

Copy link

Copy Markdown

The following commit authors need to sign the Contributor License Agreement:

[email protected]

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot added the awaiting review label

Nov 7, 2026

bedevere-app Bot commented Nov 7, 2026

Copy link

Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sobolevn requested changes

Nov 7, 2026

View reviewed changes

sobolevn left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, create an issue and describe the change first. You can re-open this PR after that.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-app Bot added awaiting changes and removed awaiting review labels

Nov 7, 2026

bedevere-app Bot commented Nov 7, 2026

Copy link

Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sobolevn closed this

Nov 7, 2026

divya-git03 commented

Nov 7, 2026

View reviewed changes

divya-git03 left a comment

Copy link

Copy Markdown

Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Title: JIT: JUMP_BACKWARD warmup counter is reset during trace recording

Description

I noticed an issue involving the JIT warmup counter for JUMP_BACKWARD instructions during trace recording.

The current implementation appears to reset the warmup counter in a way that can cause unexpected warmup behaviour when recording a JIT trace.

Expected behaviour

The JUMP_BACKWARD warmup counter should maintain the intended state across trace recording and subsequent interpreter execution.

Proposed change

I have prepared a potential fix that adjusts the warmup counter handling to prevent the unintended reset.

I would appreciate feedback on whether this is the expected behaviour and whether the proposed approach is appropriate.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

sobolevn added the AI-guidelines-not-met The contribution does not meet our guidelines for using AI tools and is closed automatically. label

Nov 7, 2026

Reviewers

sobolevn

sobolevn requested changes

markshannon

Awaiting requested review from markshannon

markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

AI-guidelines-not-met

The contribution does not meet our guidelines for using AI tools and is closed automatically.

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.