GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-161657: Fix SOL_SOCKET options on AF_VSOCK sockets by bvolpato · Pull Request #161658 · python/cpython

Conversation

@bvolpato

@bvolpato bvolpato commented Nov 9, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Fixes #161657.

On an AF_VSOCK socket, setsockopt() rejects a packed SO_LINGER value and getsockopt() rejects the buffer size needed to read it. Limit VSOCK's 64-bit integer handling to the AF_VSOCK option level so SOL_SOCKET options use their usual types.

The regression uses a Unix socket descriptor so it can run without a VSOCK device. It reproduces the failure on main. I tested locally on a Linux arm64 debug build. The full test_socket module passed, and I verified the SO_LINGER round trip on a real VSOCK socket.

I used AI assistance for this change.

  • Issue: AF_VSOCK sockets reject buffered SOL_SOCKET options #161657

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

chatgpt-codex-connector[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@python-cla-bot

python-cla-bot Bot commented Nov 9, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot added the awaiting review label Nov 9, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Nov 9, 2026
AF_VSOCK sockets reject buffered SOL_SOCKET options #161657
Open
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 9, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-09T06:18:04.178607Z 02baf30 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bvolpato

bvolpato commented Nov 9, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Author

The refreshed Tests run 42638363842 passed on head 3c3415775df67ddb13475a5884b9005466cf81e1, and the CLA check passes. My earlier request to rerun the old head’s dependency-download failures is superseded.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bvolpato
pythongh-161657: Fix SOL_SOCKET options on AF_VSOCK sockets
3c34157
@bvolpato
bvolpato force-pushed the bvolpato/vsock-socket-option-level branch from 02baf30 to 3c34157 Compare November 9, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AF_VSOCK sockets reject buffered SOL_SOCKET options

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@bvolpato
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.