GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-161503: Check hostname in `ssl.get_server_certificate` with custom `ca_certs` (GH-161507) by brettcs · Pull Request #161671 · python/cpython

Conversation

@brettcs

@brettcs brettcs commented Nov 9, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 8dde46e)

  • Issue: ssl.get_server_certificate(addr, ca_certs=...) verifies the chain but never the identity #161503

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@brettcs
[3.11] pythongh-161503: Check hostname in `ssl.get_server_certificate…
46876c7 
…` with custom `ca_certs` (pythonGH-161507)

(cherry picked from commit 8dde46e)

Co-authored-by: Brett Smith <[email protected]>
@bedevere-app bedevere-app Bot added the awaiting review label Nov 9, 2026
This was referenced Nov 9, 2026
ssl.get_server_certificate(addr, ca_certs=...) verifies the chain but never the identity #161503
Open
gh-161503: Check hostname in ssl.get_server_certificate with custom ca_certs #161507
Merged
@read-the-docs-community

read-the-docs-community Bot commented Nov 9, 2026

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #35756946 | 📁 Comparing 46876c7 against main (37b5cc4)

  🔍 Preview build  

538 files changed · + 18 added · ± 435 modified · - 85 deleted

+ Added

  • c-api/objbuffer.html
  • distutils/_setuptools_disclaimer.html
  • distutils/apiref.html
  • distutils/builtdist.html
  • distutils/commandref.html
  • distutils/configfile.html
  • distutils/examples.html
  • distutils/extending.html
  • distutils/index.html
  • distutils/introduction.html
  • and 8 more...

± Modified

  • about.html
  • bugs.html
  • copyright.html
  • glossary.html
  • index.html
  • license.html
  • py-modindex.html
  • c-api/allocation.html
  • c-api/apiabiversion.html
  • c-api/arg.html
  • and 425 more...

- Deleted

  • 404.html
  • improve-page-nojs.html
  • improve-page.html
  • _static/tachyon-example-flamegraph.html
  • _static/tachyon-example-heatmap.html
  • builtins/constants.html
  • builtins/exceptions.html
  • builtins/functions.html
  • builtins/index.html
  • builtins/stdtypes.html
  • and 75 more...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@brettcs

brettcs commented Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

Doctest check failed early trying to build a container image. One of those weird transient issues where a package wasn't available. Not related to the branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sethmlarson
sethmlarson approved these changes Nov 9, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sethmlarson sethmlarson sethmlarson approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@brettcs @sethmlarson
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.