GeezerVison is showing github.com — gh-161692: Fix stack buffer overflow in functools.partial keyword merge by emirplus · Pull Request #161698 · python/cpython
Conversation
emirplus
commented
Nov 9, 2026
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Fixes #161692.
In partial_vectorcall, pto_nkwds was counted before inspecting call keyword arguments. When overlapping keywords were merged into partial_keywords, custom __eq__ implementations on keyword names could execute arbitrary Python code and mutate p.keywords (e.g. adding thousands of entries or clearing the dictionary).
When keys were added, the subsequent PyDict_Next loop overfilled the fixed-size stack buffer / tuple (tot_kwnames), corrupting stack frames and causing SIGABRT (*** stack smashing detected ***). When keys were removed, assert(i == pto_nkwds) failed or null pointers were accessed.
Snapshotting partial_keywords via PyDict_Copy before key lookup and merging ensures the dictionary traversed for vectorcall arguments cannot be mutated during keyword merge.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
rhettinger
Awaiting requested review from rhettinger
rhettinger is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.