GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-161692: Fix stack buffer overflow in functools.partial keyword merge by emirplus · Pull Request #161698 · python/cpython

Conversation

@emirplus

@emirplus emirplus commented Nov 9, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fixes #161692.

In partial_vectorcall, pto_nkwds was counted before inspecting call keyword arguments. When overlapping keywords were merged into partial_keywords, custom __eq__ implementations on keyword names could execute arbitrary Python code and mutate p.keywords (e.g. adding thousands of entries or clearing the dictionary).

When keys were added, the subsequent PyDict_Next loop overfilled the fixed-size stack buffer / tuple (tot_kwnames), corrupting stack frames and causing SIGABRT (*** stack smashing detected ***). When keys were removed, assert(i == pto_nkwds) failed or null pointers were accessed.

Snapshotting partial_keywords via PyDict_Copy before key lookup and merging ensures the dictionary traversed for vectorcall arguments cannot be mutated during keyword merge.

  • Issue: functools.partial: changing p.keywords during the call's keyword merge overflows a stack buffer #161692

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@emirplus
pythongh-161692: Fix stack buffer overflow in functools.partial keywo…
0deab6c
…rd merge
@emirplus
emirplus requested a review from rhettinger as a code owner November 9, 2026 19:07
@bedevere-app bedevere-app Bot mentioned this pull request Nov 9, 2026
functools.partial: changing p.keywords during the call's keyword merge overflows a stack buffer #161692
Open
@bedevere-app bedevere-app Bot added the awaiting review label Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

functools.partial: changing p.keywords during the call's keyword merge overflows a stack buffer

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@emirplus
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.