GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-161689: Insert at start for a backward slice assignment to an Element by aozmekik · Pull Request #161736 · python/cpython

Conversation

@aozmekik

@aozmekik aozmekik commented Nov 10, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The C Element.__setitem__ shifted the children from stop but wrote the new ones from start, so e[5:2] = [x] duplicated one child without taking a reference and overwrote another. This normalizes stop to start the same way list does (adjust_slice_indexes in Objects/listobject.c), which is what the Python implementation already gets from its list.

The new test compares a few backward slices with the same assignment on a list, so it covers both implementations. On main the C one crashes: the example from the issue segfaults on a debug build, and with ASan, dropping the parent gives a heap-use-after-free in element_dealloc. With the fix, both builds keep all the children, test_xml_etree and test_xml_etree_c pass, and -R 3:3 on the slice tests shows no leaks.

  • Issue: ElementTree slice assignment with start greater than stop duplicates a child without owning its second reference #161689

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@aozmekik
pythongh-161689: Insert at start for a backward slice assignment to a…
59c7612
…n Element

The C implementation of Element.__setitem__ shifted the children from
stop but wrote the new ones from start, so e[5:2] = [x] duplicated one
child without a new reference and overwrote another. Normalize stop to
start as list does.
@bedevere-app bedevere-app Bot mentioned this pull request Nov 10, 2026
ElementTree slice assignment with start greater than stop duplicates a child without owning its second reference #161689
Open
@bedevere-app bedevere-app Bot added the awaiting review label Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@aozmekik
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.