GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-161735: Update zlib-ng to 2.2.5 on Windows by zware · Pull Request #161813 · python/cpython

Conversation

@zware

@zware zware commented Nov 11, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Windows: update zlib-ng to 2.2.5 (PGO builds with Visual Studio 17.11 decompress wrongly on AVX-512 CPUs) #161735

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zware
pythongh-161735: Update zlib-ng to 2.2.5 on Windows
7727582
@zware
zware requested a review from a team as a code owner November 11, 2026 16:46
@zware zware added type-bug An unexpected behavior, bug, or error OS-windows build The build process and cross-build dependencies Pull requests that update a dependency file needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Nov 11, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Nov 11, 2026
Windows: update zlib-ng to 2.2.5 (PGO builds with Visual Studio 17.11 decompress wrongly on AVX-512 CPUs) #161735
Open
@bedevere-app bedevere-app Bot added the awaiting core review label Nov 11, 2026
@zware

zware commented Nov 11, 2026

Copy link
Copy Markdown
Member Author

@maikschulze, please check that just the version bump is sufficient to address your issue.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zware
fixup! pythongh-161735: Update zlib-ng to 2.2.5 on Windows
dd7fe7c
@zware
zware requested a review from sethmlarson as a code owner November 11, 2026 17:03
@zooba

zooba commented Nov 11, 2026

Copy link
Copy Markdown
Member

I don't suppose we had a test case for the bug?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zware

zware commented Nov 11, 2026

Copy link
Copy Markdown
Member Author

IIUC, the symptom is failures of existing tests on certain configurations (which we apparently don't have in CI or buildbots).
zooba and StanFromIreland reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
StanFromIreland
StanFromIreland approved these changes Nov 11, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Nov 11, 2026
zooba
zooba approved these changes Nov 11, 2026
View reviewed changes
@maikschulze

maikschulze commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

please check that just the version bump is sufficient to address your issue.

Yes, the version bump is enough. I built this PR (dd7fe7c) and its base (0ada998) with PCbuild\build.bat -p x64 --pgo and VS 17.11.3 (MSVC 14.41) on a Ryzen 9 7950X:

  • base (zlib-ng 2.2.4): test_zlib, test_gzip and test_tarfile fail as in the issue (test_decompressmaxlen, test_decompressmaxlenflush, test_write_seek_write, GzipStreamReadTest.test_compare_members)
  • this PR (zlib-ng 2.2.5): test_zlib, test_gzip, test_tarfile and test_zipfile all pass

The zlib-ng-2.2.5 tag in cpython-source-deps has the same files as the upstream 2.2.5 release. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba approved these changes
@StanFromIreland StanFromIreland StanFromIreland approved these changes
@sethmlarson sethmlarson Awaiting requested review from sethmlarson sethmlarson is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting merge build The build process and cross-build dependencies Pull requests that update a dependency file needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes OS-windows type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@zware @zooba @maikschulze @StanFromIreland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.