GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-156812: Check structural rules when serializing in xml.dom.minidom by serhiy-storchaka · Pull Request #161830 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Nov 11, 2026

Copy link
Copy Markdown
Member

Only the structure is checked, not the characters.

A comment ending with - was fused with the closing --> into --->.

A processing instruction was not checked at all: ?> in the data silently closed it, and the reserved target xml produced a document which cannot be parsed.

The identifiers of the document type declaration were interpolated into single quotes without checks, so an identifier containing a quote or other illegal character produced XML which is not well-formed, and a public identifier without a system identifier produced the literal None.

  • Issue: xml.dom.minidom: serializing a comment ending in '-' silently produces non-well-formed XML #156812

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@serhiy-storchaka
pythongh-156812: Check structural rules when serializing in xml.dom.m…
c4f9ac7
…inidom

Only the structure is checked, not the characters.

A comment ending with '-' was fused with the closing '-->' into '--->'.
A processing instruction was not checked at all: '?>' in the data silently
closed it, and the reserved target 'xml' produced a document which cannot
be parsed.  The identifiers of the document type declaration were
interpolated into single quotes without checks, so an identifier containing
a quote or other illegal character produced XML which is not well-formed,
and a public identifier without a system identifier produced the literal
'None'.
@bedevere-app bedevere-app Bot added the awaiting core review label Nov 11, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Nov 11, 2026
xml.dom.minidom: serializing a comment ending in '-' silently produces non-well-formed XML #156812
Open
@read-the-docs-community

read-the-docs-community Bot commented Nov 11, 2026

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #35823570 | 📁 Comparing c4f9ac7 against main (a872024)

  🔍 Preview build  

2 files changed
± library/xml.dom.minidom.html
± whatsnew/changelog.html
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.