GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix missing comma in test_time tzname assertion by andresdelfino · Pull Request #161832 · python/cpython

Conversation

@andresdelfino

@andresdelfino andresdelfino commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

In test_tzset, ('AEST' 'EST') is implicit string concatenation rather than a tuple, so assertIn(time.tzname[0], ('AEST' 'EST')) was a substring check against 'AESTEST' and would also accept values such as 'ST' or 'TES'. Adding the missing comma makes it the intended membership check, matching the tzname[1] check on the next line.

Found while auditing test assertions for misused arguments.

Test-only change, so this should be fine for skip issue / skip news. Tested locally on Linux, where the Victoria timezone gives time.tzname == ('AEST', 'AEDT'); test_time passes.

🤖 Generated with Claude Code

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@andresdelfino @claude
Fix missing comma in test_time tzname assertion
dcc4a6a 
('AEST' 'EST') is implicit string concatenation rather than a tuple, so
the assertIn() in test_tzset was a substring check against 'AESTEST'.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@andresdelfino
andresdelfino requested review from StanFromIreland and pganssle as code owners November 11, 2026 21:50
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting review labels Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner
@StanFromIreland StanFromIreland Awaiting requested review from StanFromIreland StanFromIreland is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@andresdelfino
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.