GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-87465: Bypass sys.modules when finding module specs in pyclbr by yhay81 · Pull Request #161864 · python/cpython

Conversation

@yhay81

@yhay81 yhay81 commented Nov 12, 2026

Copy link
Copy Markdown

pyclbr._readmodule() previously called importlib.util._find_spec_from_path(), which checks sys.modules before searching search_path. Because pyclbr maintains its own _modules cache and inspects source files from the search path without importing them, consulting sys.modules caused two problems:

  1. Browsing any module with import __main__ (such as pdb or doctest) when sys.modules['__main__'].__spec__ is None (or another synthetic module in sys.modules without __spec__) raised ValueError instead of treating an unresolvable import as ModuleNotFoundError.
  2. When __main__.py existed on the given search path, sys.modules['__main__'] shadowed it with the running process's own __main__ module.

Switch pyclbr._readmodule() to call importlib._bootstrap._find_spec(fullmodule, search_path) directly, remove the temporary_main_spec() workaround from Lib/test/test_pyclbr.py, and add regression tests.

  • Issue: pyclbr.readmodule_ex traversing "import __main__": dies with ValueError: __main__.__spec__ is None / is not set #87465

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@yhay81
pythongh-87465: Bypass sys.modules when finding module specs in pyclbr
6596cf1
@bedevere-app bedevere-app Bot mentioned this pull request Nov 12, 2026
pyclbr.readmodule_ex traversing "import __main__": dies with ValueError: __main__.__spec__ is None / is not set #87465
Open
@bedevere-app bedevere-app Bot added the awaiting review label Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@yhay81
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.