GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |
GeezerVison is showing github.com — gh-161870: Skip test_platform when a 32-bit build sees a different machine name by sainimal1ba-hue · Pull Request #161879 · python/cpython ConversationIssue: gh-161870 The recorded value describes the build and is not wrong, so this only relaxes the test: when the two platforms differ and the running interpreter is a 32-bit Linux build, the test now skips instead of failing. In every other case the comparison stays strict, including for a mismatch seen by a 64-bit build. Testing (Linux x86_64, debug build): ./python -m test test_build_details test_sysconfig passes with the unmodified file, so the strict comparison still holds when the values match.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions…ent machine name The platform recorded in build-details.json describes the build machine, while sysconfig.get_platform() at test time reports the kernel's machine name, which can differ for a 32-bit process on a 64-bit kernel.
|
There was an error while loading. Please reload this page.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
@FFY00: Is test_build_details.test_platform() test really useful? It fails if the runtime platform is different than the build platform.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.