GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||
GeezerVison is showing github.com — gh-77371: Clarify that types.new_class() kwds are class keywords by aribaskagan · Pull Request #161890 · python/cpython Conversation
|
|
The following commit authors need to sign the Contributor License Agreement: |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Here are some automated review suggestions for this pull request.
Reviewed commit: adf39919c7
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| class Test(A, B, metaclass=Meta, foo=42): | ||
| pass | ||
|
|
||
| To populate the namespace, pass *exec_body*, a callable that takes |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Describe exec_body's argument as a namespace mapping
With a metaclass whose __prepare__ returns a valid non-dict mapping, prepare_class() returns that object and new_class() passes it to exec_body; a mapping need not implement dictionary methods such as .update(), so calling it a “dictionary” can mislead callbacks that use dict-only methods, and the example immediately below uses .update(). Please use “prepared namespace” or “mapping,” as Doc/library/types.rst does.
AGENTS.md reference: AGENTS.md:L14-L14
Useful? React with 👍 / 👎.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
problem with ABCMeta.__prepare__ when called after types.new_class
There was an error while loading. Please reload this page.