GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-38396: dump(node) instead of repr(node) on ast.literal_eval by isidentical · Pull Request #16620 · python/cpython

Conversation

@isidentical

@isidentical isidentical commented Oct 7, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue38396

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@isidentical
bpo-38396: dump(node) instead of repr(node) on ast.literal_eval
9d25107
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Oct 7, 2019
@bedevere-bot bedevere-bot added the awaiting review label Oct 7, 2019
vstinner
vstinner reviewed Dec 14, 2019
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please try to write a test?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@isidentical

isidentical commented Dec 14, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

bpo-38396 resolved as duplicate of bpo-32888 and #340 is about fixing it. It has a slightly different approach but resolves the same problem so I think this PR can be closed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request Dec 14, 2019
bpo-32888: Improve exception message in ast.literal_eval #340
Closed
@vstinner

vstinner commented Dec 14, 2019

Copy link
Copy Markdown
Member

Oh, @ilevkivskyi seems to be against this PR, so I close it: https://bugs.python.org/issue38396#msg354132 I agree that PR #340 should produce shorter and better error message.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner closed this Dec 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@isidentical @vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.