GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-57187: Add support for extended attributes on FreeBSD by worr · Pull Request #1690 · python/cpython

Conversation

@worr

@worr worr commented May 21, 2017 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Extended attributes are supported on FreeBSD, but have
a different API than on Linux. This implements a compatibility
layer so that the same set of python functions map to the
equivalent FreeBSD functions.

This is the patch for issue: https://bugs.python.org/issue12978

https://bugs.python.org/issue12978

  • Issue: Figure out extended attributes on BSDs #57187

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni

the-knights-who-say-ni commented May 21, 2017

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label May 21, 2017
@worr worr changed the title Add support for extended attributes on FreeBSD issue12978: Add support for extended attributes on FreeBSD May 21, 2017
@worr worr changed the title issue12978: Add support for extended attributes on FreeBSD bpo-12978: Add support for extended attributes on FreeBSD May 21, 2017
@worr
worr force-pushed the feature/exattrs-bsd branch from 927aad5 to ed5d302 Compare May 21, 2017 05:37
@the-knights-who-say-ni the-knights-who-say-ni added CLA signed and removed CLA not signed labels May 21, 2017
@Mariatta Mariatta added needs rebase and removed needs rebase labels Oct 9, 2017
@brettcannon brettcannon added the awaiting review label Feb 2, 2018
@worr
worr force-pushed the feature/exattrs-bsd branch from ed5d302 to 22dd7e4 Compare March 3, 2018 07:32
@worr
Add support for extended attributes on FreeBSD
123b203 
Extended attributes are supported on FreeBSD, but have
a different API than on Linux. This implements a compatibility
layer so that the same set of python functions map to the
equivalent FreeBSD functions.
@worr
worr force-pushed the feature/exattrs-bsd branch from 22dd7e4 to 123b203 Compare March 3, 2018 07:39
grimreaper
grimreaper approved these changes May 16, 2018
View reviewed changes
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels May 16, 2018
@brettcannon brettcannon added the type-feature A feature request or enhancement label Mar 26, 2019
@github-actions

github-actions Bot commented Feb 19, 2022

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Feb 19, 2022
@vstinner vstinner added the OS-freebsd label Apr 21, 2022
@ezio-melotti ezio-melotti removed the CLA signed label Jul 13, 2022
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Jul 28, 2022
@github-actions

github-actions Bot commented Aug 28, 2022

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Aug 28, 2022
iritkatriel
iritkatriel requested changes Nov 29, 2022
View reviewed changes

@iritkatriel iritkatriel left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has merge conflicts now.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting changes and removed awaiting core review labels Nov 29, 2022
@bedevere-bot

bedevere-bot commented Nov 29, 2022

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Nov 30, 2022
@github-actions

github-actions Bot commented Dec 31, 2022

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Dec 31, 2022
@benjaminp benjaminp mentioned this pull request Apr 28, 2023
Figure out extended attributes on BSDs #57187
Open
@arhadthedev arhadthedev added the extension-modules C modules in the Modules dir label Apr 29, 2023
@sorcio sorcio mentioned this pull request Apr 29, 2023
gh-57187: add xattr support for FreeBSD and macOS #103994
Closed
6 tasks
@arhadthedev arhadthedev changed the title bpo-12978: Add support for extended attributes on FreeBSD gh-57187: Add support for extended attributes on FreeBSD Apr 29, 2023
@arhadthedev

arhadthedev commented Apr 29, 2023

Copy link
Copy Markdown
Member

Superseded by gh-103994.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@arhadthedev arhadthedev closed this Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel requested changes
+1 more reviewer
@grimreaper grimreaper grimreaper approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting changes extension-modules C modules in the Modules dir OS-freebsd stale Stale PR or inactive for long period of time. type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@worr @the-knights-who-say-ni @bedevere-bot @arhadthedev @grimreaper @iritkatriel @brettcannon @vstinner @Mariatta @ezio-melotti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.