GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-2986: Allow disabling difflib's automatic junk heuristic by liamFerris · Pull Request #17082 · python/cpython

Conversation

@liamFerris

@liamFerris liamFerris commented Nov 7, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown 
[bpo-2986](https://bugs.python.org/issue2986): Allow disabling difflib's automatic junk heuristic

Added parameter for autojunk to the Differ class and the ndiff method to allow disabling the automatic junk heuristic.

I am using difflib extensively as part of a current project. We are working across a large amount of text, and for our purposes quality is preferred over speed. We have examples of where the diff algorithm fails (fails meaning treats the majority of our input as one large deletion / addition) with autojunking enabled and does not without, meaning we are required to set this parameter to false for our purposes.

This parameter is not accessible to us from the API provided by difflib currently. To resolve this we have copied this out and modified it in a similar way to this PR.

The issue we are facing plus the suggestion to allow this parameter to be configured it mentioned by others in bpo-2986.

Thanks, Liam

https://bugs.python.org/issue2986

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@liamFerris
autojunk parameter added to ndiff method and to Differ class so that …
1c5718d 
…autojunking can be turned on or off when calling ndiff. Using default value similar to SequenceMatcher
@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label Nov 7, 2019
@the-knights-who-say-ni

the-knights-who-say-ni commented Nov 7, 2019

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@liamFerris

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting review label Nov 7, 2019
@csabella csabella removed the CLA not signed label Nov 21, 2019
@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label Nov 21, 2019
@csabella csabella removed the CLA not signed label Jan 25, 2020
@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label Jan 25, 2020
@csabella

csabella commented Jan 25, 2020

Copy link
Copy Markdown
Contributor

@liamFerris, the bot isn't finding a signed CLA for you. We are unable to accept contributions that don't have a signed CLA, so please take a look at the directions above to submit that. Thank you!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@csabella csabella removed the CLA not signed label Feb 3, 2020
@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label Feb 3, 2020
@csabella

csabella commented Feb 3, 2020

Copy link
Copy Markdown
Contributor

I'm going to close this PR as the CLA hasn't been signed. It can be reopened once that is taken care of. Thank you.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@csabella csabella closed this Feb 3, 2020
@Lenormju Lenormju mentioned this pull request Jul 17, 2026
Difflib creates unreasonably large diffs #118150
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@liamFerris @the-knights-who-say-ni @csabella @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.