GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.8] bpo-38453: Ensure ntpath.realpath correctly resolves relative paths (GH-16967) by zooba · Pull Request #17174 · python/cpython

Conversation

@zooba

@zooba zooba commented Nov 15, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Ensure isabs() is always True for \?\ prefixed paths
Avoid unnecessary usage of readlink() to avoid resolving broken links incorrectly

https://bugs.python.org/issue38453

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zooba
bpo-38453: Ensure ntpath.realpath correctly resolves relative paths (p…
0049b22 
…ythonGH-16967)

Ensure isabs() is always True for \\?\ prefixed paths
Avoid unnecessary usage of readlink() to avoid resolving broken links incorrectly
Ensure shutil tests run in test directory
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 15, 2019
@bedevere-bot bedevere-bot mentioned this pull request Nov 15, 2019
bpo-38453: Ensure ntpath.realpath correctly resolves relative paths #16967
Merged
@bedevere-bot bedevere-bot added type-bug An unexpected behavior, bug, or error awaiting core review labels Nov 15, 2019
zooba added 3 commits November 15, 2019 11:36
@zooba
Revert shutil test changes for backport
df052b1
@zooba
Move temp directories under working directory
2a44825
@zooba
Try alternate fix for shutil test
589288f
@zooba
zooba merged commit 66c0f01 into python:3.8 Nov 15, 2019
@zooba
zooba deleted the bpo-38453-3.8 branch November 15, 2019 23:25
@bedevere-bot bedevere-bot removed the awaiting core review label Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@zooba @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.