GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.8] bpo-38823: Fix refleak in marshal init error path (GH-17260) by miss-islington · Pull Request #17271 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Nov 20, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 33b671e)

Co-authored-by: Brandt Bucher [email protected]

https://bugs.python.org/issue38823

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@brandtbucher @miss-islington
bpo-38823: Fix refleak in marshal init error path (pythonGH-17260)
8f47aa2 
(cherry picked from commit 33b671e)

Co-authored-by: Brandt Bucher <[email protected]>
@miss-islington
miss-islington requested a review from tiran as a code owner November 20, 2019 00:59
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 20, 2019
@bedevere-bot bedevere-bot mentioned this pull request Nov 20, 2019
bpo-38823: Clean up refleak in marshal initialization. #17260
Merged
@bedevere-bot bedevere-bot added skip news type-bug An unexpected behavior, bug, or error awaiting review labels Nov 20, 2019
vstinner
vstinner approved these changes Nov 20, 2019
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Nov 20, 2019
@miss-islington

miss-islington commented Nov 20, 2019

Copy link
Copy Markdown
Contributor Author

@brandtbucher and @vstinner: Status check is done, and it's a failure ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
2 similar comments
@miss-islington

miss-islington commented Nov 20, 2019

Copy link
Copy Markdown
Contributor Author

@brandtbucher and @vstinner: Status check is done, and it's a failure ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Nov 20, 2019

Copy link
Copy Markdown
Contributor Author

@brandtbucher and @vstinner: Status check is done, and it's a failure ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner closed this Nov 20, 2019
@miss-islington
miss-islington deleted the backport-33b671e-3.8 branch November 20, 2019 09:56
@brandtbucher brandtbucher mentioned this pull request Apr 10, 2022
Improve stdlib module initialization error handling. #83004
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@tiran tiran Awaiting requested review from tiran

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting merge skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot @brandtbucher
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.