GeezerVison is showing github.com — Add .idea and .iml to .gitignore by gfyoung · Pull Request #1764 · python/cpython
Conversation
These arose when working with the repository in IntelliJ IDE. This is a trivial PR.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@gfyoung, thanks for your PR! By analyzing the history of the files in this pull request, we identified @akheron, @zware and @zooba to be potential reviewers.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Hello, and thanks for your contribution!
I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).
Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.
Thanks again to your contribution and we look forward to looking at it!
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
gfyoung
commented
May 23, 2017
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Unfortunately our records indicate you have not signed the CLA.
I signed the CLA two days ago. How long does it take to propagate? Or should I forward the confirmation email to somebody?
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
gfyoung reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Note that a nearly identical PR (see #6) was rejected before because users can use a global .gitignore file (see also bpo-29510 for Eclipse.)
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
gfyoung
commented
May 24, 2017
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
Fair enough, though I think this comment at the end of the PR here suggests that perhaps that that suggestion should be reconsidered. I see no reason to assume that users have a global .gitignore file configured. That's seem to be just asking for accidental file commits.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Using a global .gitignore file is a best practice. That last comment was about syncing .gitignore with .hgignore.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Best practice but not required. Call me cynical, but I don't expect users to do this (in my case, I was working on a machine other than my own and accidentally committed these changes in another PR).
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|