GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add .idea and .iml to .gitignore by gfyoung · Pull Request #1764 · python/cpython

Conversation

@gfyoung

@gfyoung gfyoung commented May 23, 2017

Copy link
Copy Markdown
Contributor

These arose when working with the repository in IntelliJ IDE. This is a trivial PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@mention-bot

mention-bot commented May 23, 2017

Copy link
Copy Markdown

@gfyoung, thanks for your PR! By analyzing the history of the files in this pull request, we identified @akheron, @zware and @zooba to be potential reviewers.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@the-knights-who-say-ni

the-knights-who-say-ni commented May 23, 2017

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label May 23, 2017
@gfyoung

gfyoung commented May 23, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Unfortunately our records indicate you have not signed the CLA.

I signed the CLA two days ago. How long does it take to propagate? Or should I forward the confirmation email to somebody?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@the-knights-who-say-ni the-knights-who-say-ni added CLA signed and removed CLA not signed labels May 24, 2017
@gfyoung
Add .idea and .iml to .gitignore
c4a0f7e
@zooba zooba added the trivial label May 24, 2017
@zooba
zooba merged commit c0fa4ba into python:master May 24, 2017
@zooba

zooba commented May 24, 2017

Copy link
Copy Markdown
Member

Thanks!

gfyoung reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@gfyoung
gfyoung deleted the gitignore-add branch May 24, 2017 16:34
@berkerpeksag

berkerpeksag commented May 24, 2017

Copy link
Copy Markdown
Member

Note that a nearly identical PR (see #6) was rejected before because users can use a global .gitignore file (see also bpo-29510 for Eclipse.)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@gfyoung

gfyoung commented May 24, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Fair enough, though I think this comment at the end of the PR here suggests that perhaps that that suggestion should be reconsidered. I see no reason to assume that users have a global .gitignore file configured. That's seem to be just asking for accidental file commits.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@berkerpeksag

berkerpeksag commented May 24, 2017

Copy link
Copy Markdown
Member

Using a global .gitignore file is a best practice. That last comment was about syncing .gitignore with .hgignore.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@gfyoung

gfyoung commented May 24, 2017

Copy link
Copy Markdown
Contributor Author

Best practice but not required. Call me cynical, but I don't expect users to do this (in my case, I was working on a machine other than my own and accidentally committed these changes in another PR).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@gfyoung @mention-bot @the-knights-who-say-ni @zooba @berkerpeksag
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.