GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-1635741: Remove redundant _Py_INC_TPALLOCS in _Py_NewReference() by shihai1991 · Pull Request #17883 · python/cpython

Conversation

@shihai1991

@shihai1991 shihai1991 commented Jan 7, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue1635741

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
shi hai
Remove redundant _Py_INC_TPALLOCS in _Py_NewReference()
dc43dd3
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 7, 2020
@bedevere-bot bedevere-bot added the awaiting review label Jan 7, 2020
@shihai1991

shihai1991 commented Jan 7, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Check test_asyncio test case's failure:

(Pdb) gettotalrefcount()
-7737240
(Pdb) refs_before
-7709437
(Pdb) gettotalrefcount()-refs_before
-28019

in master branch:

(Pdb) gettotalrefcount()
505358
(Pdb) refs_before
497062
(Pdb) gettotalrefcount()-refs_before
8297

Looks like that _Py_INC_TPALLOCS in _Py_NewReference() and this PR should be closed.
Compare to _Py_ForgetReference(), I don't know why _Py_NewReference() need _Py_INC_TPALLOCS. Do you know the reason? @vstinner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@shihai1991 shihai1991 closed this Jan 7, 2020
@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Py_Finalize() doesn't clear all Python objects at exit #44470
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@shihai1991 @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.