GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-1635741: Port _codecs extension module to multiphase initialization (PEP 489) by shihai1991 · Pull Request #18065 · python/cpython

Conversation

@shihai1991

@shihai1991 shihai1991 commented Jan 19, 2020 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue1635741

Automerge-Triggered-By: @encukou

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@shihai1991
Port _codecs extension module to multiphase initialization(PEP 489)
bd241d2
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 19, 2020
@bedevere-bot bedevere-bot added the awaiting review label Jan 19, 2020
@blurb-it
📜🤖 Added by blurb_it.
fbbae77
@shihai1991
shihai1991 requested review from encukou and ncoghlan January 31, 2020 15:55
ncoghlan
ncoghlan approved these changes Feb 2, 2020
View reviewed changes

@ncoghlan ncoghlan left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (given the relative simplicity of the module), but until I've reviewed a few more of these, I'd like to get a +1 from @encukou as well.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
shihai1991 reacted with laugh emoji
All reactions
  • 😄 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Feb 2, 2020
@encukou

encukou commented Feb 4, 2020

Copy link
Copy Markdown
Member

The catch it that the simple module exposes complex API, and multiphase init asserts that the module is expected to support sub-interpreters. Any module that manipulates some registry should get some extra attention :)
All looks OK here, since thePyCodec_* functions all use interpreter-specific state.
@Dormouse759, do you want to take a look?
shihai1991 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou encukou changed the title bpo-1635741: Port _codecs extension module to multiphase initialization(PEP 489) bpo-1635741: Port _codecs extension module to multiphase initialization (PEP 489) Feb 11, 2020
@encukou encukou added the 🤖 automerge label Feb 11, 2020
@miss-islington

miss-islington commented Feb 11, 2020

Copy link
Copy Markdown
Contributor

@shihai1991: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Feb 11, 2020

Copy link
Copy Markdown
Contributor

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit 1ea45ae into python:master Feb 11, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 11, 2020
@shihai1991

shihai1991 commented Feb 11, 2020

Copy link
Copy Markdown
Member Author

Thanks, guys.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou

encukou commented Feb 11, 2020

Copy link
Copy Markdown
Member

Thank you!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Py_Finalize() doesn't clear all Python objects at exit #44470
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncoghlan ncoghlan ncoghlan approved these changes
@encukou encukou Awaiting requested review from encukou

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@shihai1991 @encukou @miss-islington @ncoghlan @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.