GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.6] bpo-39401: Avoid unsafe DLL load on Windows 7 and earlier (GH-18231) by zooba · Pull Request #18233 · python/cpython

Conversation

@zooba

@zooba zooba commented Jan 28, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue39401

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zooba
bpo-39401: Avoid unsafe DLL load on Windows 7 and earlier
eafce17
@bedevere-bot bedevere-bot added the type-security A security issue label Jan 28, 2020
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 28, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Jan 28, 2020
@zooba
Remove extra brace
01942ca
@zooba zooba self-assigned this Jan 28, 2020
@ned-deily

ned-deily commented Jan 29, 2020

Copy link
Copy Markdown
Member

@zooba, Let me know when you think this PR is ready to be merged for 3.6.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zooba
Update 2020-01-28-20-54-09.bpo-39401.he7h_A.rst
9e3d92d
@zooba zooba added awaiting merge and removed awaiting core review labels Jan 30, 2020
@zooba

zooba commented Jan 30, 2020

Copy link
Copy Markdown
Member Author

@ned-deily Whenever you're ready, though I'd say probably don't be ready until the buildbots have signed off on the other branches.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zooba

zooba commented Jan 31, 2020

Copy link
Copy Markdown
Member Author

@ned-deily Buildbots for 3.7 and 3.8 are happy, and the only unhappy ones on master are the unsupported ones, so feel free to merge this whenever you like.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ned-deily
ned-deily merged commit 51332c4 into python:3.6 Jan 31, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label Jan 31, 2020
@zooba
zooba deleted the bpo-39401-3.6 branch February 5, 2020 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@zooba zooba

Labels

type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@zooba @ned-deily @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.