GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-75008: guess lineterminator in csv.Sniffer by vmax · Pull Request #18336 · python/cpython

Conversation

@vmax

@vmax vmax commented Feb 3, 2020 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

https://bugs.python.org/issue30825

  • Issue: csv.Sniffer does not detect lineterminator #75008

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
vmax added 2 commits February 3, 2020 21:43
@vmax
bpo-30825: guess lineterminator in csv.Sniffer
fec87c9
@vmax
Fix unit test to cover weird or no terminator case (os.linesep)
f99b927
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 3, 2020
@bedevere-bot bedevere-bot added the awaiting review label Feb 3, 2020
@vmax vmax mentioned this pull request Feb 3, 2020
bpo-30825: guess lineterminator in csv.Sniffer #2529
Closed
@vmax vmax changed the title Bpo 30825 bpo-30825: guess lineterminator in csv.Sniffer Feb 3, 2020
@vmax
Do not use raw strings in tests
1f9bdc6
@vmax
vmax force-pushed the bpo-30825 branch from 9bdca9e to 1f9bdc6 Compare February 3, 2020 19:31
@vmax
vmax requested a review from csabella February 3, 2020 19:32
@csabella
csabella removed their request for review February 4, 2020 00:34
@vmax vmax mannequin mentioned this pull request Apr 10, 2022
csv.Sniffer does not detect lineterminator #75008
Closed
@ezio-melotti ezio-melotti removed the CLA signed label Jul 13, 2022
rruuaanng
rruuaanng reviewed Oct 9, 2024
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2018-02-12-05-10-28.bpo-30825.t0RXql.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/csv.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
vmax added 2 commits October 10, 2024 08:38
@vmax
address review comments
e1e5316
@vmax
Merge branch 'main' into bpo-30825
1b15837
rruuaanng
rruuaanng reviewed Oct 10, 2024
View reviewed changes

@rruuaanng rruuaanng left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe csv.py should be sent to another reviewer for review.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@github-actions

github-actions Bot commented Apr 7, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 7, 2026
@serhiy-storchaka

serhiy-storchaka commented Jul 21, 2026

Copy link
Copy Markdown
Member

Thank you for the patch, and sorry that it was left without attention for so long. The sniffer was rewritten on the main branch (gh-83273) and this patch no longer applies.

It should be easier now: the sample is split into lines keeping their line breaks, so detection can count '\r\n', '\n' and '\r' in a _detect_lineterminator() method, next to _detect_doublequote(). Note that falling back to os.linesep makes the result platform dependent; '\r\n' looks better for a sample without any line break.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka serhiy-storchaka changed the title bpo-30825: guess lineterminator in csv.Sniffer gh-75008: guess lineterminator in csv.Sniffer Jul 21, 2026
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Jul 26, 2026
@serhiy-storchaka serhiy-storchaka mentioned this pull request Aug 1, 2026
gh-75008: Detect the lineterminator in csv.Sniffer.sniff() #155061
Merged
@serhiy-storchaka

serhiy-storchaka commented Aug 1, 2026

Copy link
Copy Markdown
Member

#155061 implements this on the new engine. The only detail not covered above: the terminator is chosen by a majority vote among the line endings, with a tie broken in the order '\r\n', '\n', '\r'.

Closing as superseded. Thank you again for the patch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka serhiy-storchaka closed this Aug 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@rruuaanng rruuaanng rruuaanng left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@vmax @serhiy-storchaka @rruuaanng @the-knights-who-say-ni @ezio-melotti @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.