GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-1635741: Calling Py_INCREF() after PyModule_AddObject() success to run by shihai1991 · Pull Request #18365 · python/cpython

Conversation

@shihai1991

@shihai1991 shihai1991 commented Feb 5, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue1635741

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@shihai1991
Calling Py_DECREF() if PyModule_AddObject() fails to run
d2fd48f
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 5, 2020
@bedevere-bot bedevere-bot added the awaiting review label Feb 5, 2020
@shihai1991

shihai1991 commented Feb 5, 2020

Copy link
Copy Markdown
Member Author

Oh, it is generated file, i will check this operation soon.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@shihai1991
update asdl_c.py
c00cfa7
@shihai1991 shihai1991 changed the title bpo-1635741: Calling Py_DECREF() if PyModule_AddObject() fails to run bpo-1635741: Calling Py_INCREF() after PyModule_AddObject() success to run Feb 5, 2020
@shihai1991

shihai1991 commented Feb 5, 2020

Copy link
Copy Markdown
Member Author

cc @vstinner Hi, victor. It's a small fix. pls review it if you have free time.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@shihai1991
shihai1991 requested a review from vstinner February 5, 2020 14:26
@vstinner

vstinner commented Feb 5, 2020

Copy link
Copy Markdown
Member

cc @pablogsal @isidentical
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@isidentical

isidentical commented Feb 5, 2020

Copy link
Copy Markdown
Member

I recently saw a PR from @brandtbucher about a more general change that already includes this if I am not mistaken. Check out #17276 (it moves incref after the check by moving check upper). I am in favor of #17276 because it handles the case better also it opened before this PR
brandtbucher reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@brandtbucher

brandtbucher commented Feb 5, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I'm also working my way through the other broken modules in bpo-38823. I need to land #17298 before I can make further progress, though.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
brandtbucher
brandtbucher requested changes Feb 5, 2020
View reviewed changes

@brandtbucher brandtbucher left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, my PR #17276 is a more comprehensive fix.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Feb 5, 2020
@brandtbucher brandtbucher added the type-bug An unexpected behavior, bug, or error label Feb 5, 2020
@shihai1991

shihai1991 commented Feb 6, 2020

Copy link
Copy Markdown
Member Author

Oh, thank you for quick feedback, guys.
I checked Brandt's PRs, its enhance very nice. Pls go ahead, thanks. I will subscribe your PRs ;)
brandtbucher reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@shihai1991 shihai1991 closed this Feb 6, 2020
@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Py_Finalize() doesn't clear all Python objects at exit #44470
Closed
@brandtbucher brandtbucher mentioned this pull request Apr 10, 2022
Improve stdlib module initialization error handling. #83004
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucher brandtbucher brandtbucher requested changes
@vstinner vstinner Awaiting requested review from vstinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@shihai1991 @vstinner @isidentical @brandtbucher @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.