GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — bpo-37207: Use vectorcall for range() by encukou · Pull Request #18464 · python/cpython

Conversation

encukou commented Feb 11, 2020 •

edited by miss-islington

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

This continues the range() part of #13930. The complete pull request is stalled on discussions around dicts, but range() should not be controversial. (And I plan to open PRs for other parts if this is merged.)
On top of Mark's change, I unified range_new and range_vectorcall, which had a lot of duplicate code.

https://bugs.python.org/issue37207

Automerge-Triggered-By: @encukou

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

markshannon and others added 3 commits

February 11, 2020 17:08


          Use vectorcall for range()

b4f3271


          Add news entry.

6d8063b


          Unify implementations of range_new and range_vectorcall

804e18c

encukou requested review from jdemeyer, markshannon, methane and tirkarthi

February 11, 2020 16:37

the-knights-who-say-ni added the CLA signed label

Feb 11, 2020

bedevere-bot added the awaiting core review label

Feb 11, 2020

encukou mentioned this pull request

Feb 11, 2020

bpo-37207: Use PEP 590 vectorcall to speed up range(), list() and dict() by about 30% #13930

Closed

vstinner reviewed

Feb 11, 2020

View reviewed changes

Comment thread

Objects/rangeobject.c Outdated

		range_vectorcall(PyTypeObject type, PyObject const *args,
		size_t nargsf, PyObject *kwnames)
		{
		size_t nargs = PyVectorcall_NARGS(nargsf);

vstinner Feb 11, 2020

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I didn't expect a size_t here. I opened an issue to discuss PyVectorcall_NARGS() return type: https://bugs.python.org/issue39611

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

encukou Feb 18, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return type already is Py_ssize_t. The bug was only in this patch.
(When Mark was originally writing the patch, there was a discussion of Py_ssize_t vs. size_t. Mark is a big proponent of the unsigned type, which is more correct. But also much less compatible with the existing codebase.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Objects/rangeobject.c Outdated

		*/
		static PyObject *
		range_new(PyTypeObject type, PyObject args, PyObject *kw)
		range_from_array(PyTypeObject type, PyObject const *args, size_t num_args)

vstinner Feb 11, 2020

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to use Py_ssize_t type for num_args. Usually, it's called "nargs", but I'm fine with "num_args" ;-)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

encukou Feb 18, 2020

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, Py_ssize_t is more consistent.
But I find num_args more descriptive, so I'll keep that name.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

codecov Bot commented Feb 11, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Codecov Report

Merging #18464 into master will increase coverage by 1.08%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #18464       +/-   ##
===========================================
+ Coverage   82.11%   83.20%    +1.08%     
===========================================
  Files        1955     1571      -384     
  Lines      588958   414749   -174209     
  Branches    44428    44456       +28     
===========================================
- Hits       483632   345077   -138555     
+ Misses      95677    60024    -35653     
+ Partials     9649     9648        -1

Impacted Files	Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py	`30.00% <0.00%> (-65.00%)`	⬇️
Lib/distutils/command/bdist_rpm.py	`7.63% <0.00%> (-56.88%)`	⬇️
Lib/test/test_urllib2net.py	`76.92% <0.00%> (-13.85%)`	⬇️
Lib/test/test_smtpnet.py	`78.57% <0.00%> (-7.15%)`	⬇️
Lib/ftplib.py	`63.85% <0.00%> (-6.06%)`	⬇️
Lib/test/test_ftplib.py	`87.11% <0.00%> (-4.72%)`	⬇️
Tools/scripts/db2pickle.py	`17.82% <0.00%> (-3.97%)`	⬇️
Tools/scripts/pickle2db.py	`16.98% <0.00%> (-3.78%)`	⬇️
Lib/test/test_socket.py	`71.94% <0.00%> (-3.77%)`	⬇️
Lib/test/test_asyncio/test_base_events.py	`91.84% <0.00%> (-3.30%)`	⬇️
... and 465 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3e7ea5...b4559ce. Read the comment docs.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Use Py_ssize_t for number of arguments

663d8cc

vstinner reviewed

Feb 18, 2020

View reviewed changes

Comment thread

Objects/rangeobject.c

		PyErr_Format(PyExc_TypeError,
		"range expected at most 3 arguments, got %zd",
		"range expected at most 3 arguments, got %zu",
		num_args);

vstinner Feb 18, 2020

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be reset to %zd, since num_args is signed, no?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

encukou Feb 18, 2020

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Reset format argument for Py_ssize_t to %zd

b4559ce

vstinner approved these changes

Feb 18, 2020

View reviewed changes

vstinner left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot added awaiting merge and removed awaiting core review labels

Feb 18, 2020

encukou added the 🤖 automerge label

Feb 18, 2020

miss-islington merged commit 6e35da9 into python:master

Feb 18, 2020

bedevere-bot removed the awaiting merge label

Feb 18, 2020

encukou deleted the vectorcall-newrange branch

February 18, 2020 15:13

encukou mentioned this pull request

Mar 11, 2020

bpo-37207: Use vertorcall for list() #18928

Merged

Reviewers

vstinner

vstinner approved these changes

methane

Awaiting requested review from methane

jdemeyer

Awaiting requested review from jdemeyer

tirkarthi

Awaiting requested review from tirkarthi

markshannon

Awaiting requested review from markshannon

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

encukou commented Feb 11, 2020 • edited by miss-islington Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vstinner Feb 11, 2020

Choose a reason for hiding this comment

Uh oh!

encukou Feb 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vstinner Feb 11, 2020

Choose a reason for hiding this comment

Uh oh!

encukou Feb 18, 2020

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Feb 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

vstinner Feb 18, 2020

Choose a reason for hiding this comment

Uh oh!

encukou Feb 18, 2020

Choose a reason for hiding this comment

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

encukou commented Feb 11, 2020 •

edited by miss-islington

Loading

Uh oh!

There was an error while loading. Please reload this page.

encukou Feb 18, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

codecov Bot commented Feb 11, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.