GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [WIP] bpo-35134: Move header files to Include/cpython/ by vstinner · Pull Request #18490 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Feb 12, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The whole cellobject.h API is excluded from the limited C API, so
move the header file to Include/cpython/ directory. Since
cellobject.h is included by the main Python.h: users should not be
affected by this change.

https://bugs.python.org/issue35134

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
vstinner requested a review from a team as a code owner February 12, 2020 20:33
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 12, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Feb 12, 2020
@vstinner
bpo-35134: Move header files to Include/cpython/
c459180 
The whole content of cellobject.h, classobject.h, genobject.h,
pyarena.h, pyctype.h, pydebug.h, pyfpe.h and pytime.h is excluded
from the limited C API, so move these header files to
Include/cpython/ directory. Since they are included by the main
Python.h: users should not be affected by this change. If one of
these header file is included explicitly: only include Python.h
instead.
@vstinner
vstinner requested review from 1st1, abalkin, pablogsal and pganssle as code owners February 12, 2020 21:26
@vstinner vstinner changed the title bpo-35134: Move cellobject.h header to Include/cpython/ [WIP] bpo-35134: Move header files to Include/cpython/ Feb 12, 2020
@vstinner vstinner added the DO-NOT-MERGE label Feb 12, 2020
@codecov

codecov Bot commented Feb 12, 2020

Copy link
Copy Markdown

Codecov Report

Merging #18490 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #18490     +/-   ##
=========================================
  Coverage   82.11%   82.12%             
=========================================
  Files        1956     1955      -1     
  Lines      589183   583854   -5329     
  Branches    44448    44449      +1     
=========================================
- Hits       483833   479488   -4345     
+ Misses      95701    94722    -979     
+ Partials     9649     9644      -5
Impacted Files Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py 30.00% <0.00%> (-65.00%) ⬇️
Lib/distutils/command/bdist_rpm.py 7.63% <0.00%> (-56.88%) ⬇️
Lib/test/test_urllib2net.py 76.92% <0.00%> (-13.85%) ⬇️
Lib/test/test_smtpnet.py 78.57% <0.00%> (-7.15%) ⬇️
Lib/ftplib.py 63.85% <0.00%> (-6.06%) ⬇️
Lib/test/test_ftplib.py 87.11% <0.00%> (-4.72%) ⬇️
Tools/scripts/db2pickle.py 17.82% <0.00%> (-3.97%) ⬇️
Tools/scripts/pickle2db.py 16.98% <0.00%> (-3.78%) ⬇️
Lib/test/test_socket.py 71.94% <0.00%> (-3.77%) ⬇️
Lib/test/test_asyncio/test_base_events.py 91.84% <0.00%> (-3.30%) ⬇️
... and 330 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 674935b...c459180. Read the comment docs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Mar 25, 2020

Copy link
Copy Markdown
Member Author

This change break C extension modules which explicitly include on these moved header files.

A safer approach would be to keep .h files in Include/ but move their content into a new Include/cpython/ file.

I close this PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner closed this Mar 25, 2020
@vstinner
vstinner deleted the cpython_cellobject branch March 25, 2020 16:29
@vstinner vstinner mentioned this pull request Apr 10, 2022
Add a new Include/cpython/ subdirectory for the "CPython API" with implementation details #79315
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1
@abalkin abalkin Awaiting requested review from abalkin
@pablogsal pablogsal Awaiting requested review from pablogsal
@pganssle pganssle Awaiting requested review from pganssle

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review DO-NOT-MERGE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.