GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-39573: Update clinic to use Py_IS_TYPE macro by corona10 · Pull Request #18507 · python/cpython

Conversation

@corona10

@corona10 corona10 commented Feb 14, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue39573

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 14, 2020
@bedevere-bot bedevere-bot added the awaiting review label Feb 14, 2020
@corona10
corona10 requested a review from vstinner February 14, 2020 01:12
@corona10
bpo-39573: Update clinic to use Py_IS_TYPE macro
25dc827
@corona10
corona10 force-pushed the bpo-39573-clinic branch from b531904 to 25dc827 Compare February 14, 2020 01:14
@codecov

codecov Bot commented Feb 14, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Merging #18507 into master will increase coverage by 2.65%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #18507       +/-   ##
===========================================
+ Coverage   79.46%   82.12%    +2.65%     
===========================================
  Files         384     1955     +1571     
  Lines      169290   583979   +414689     
  Branches        0    44450    +44450     
===========================================
+ Hits       134529   479572   +345043     
- Misses      34761    94765    +60004     
- Partials        0     9642     +9642
Impacted Files Coverage Δ
Programs/_testembed.c 89.43% <0.00%> (-0.13%) ⬇️
Lib/test/test_reprlib.py 95.75% <0.00%> (ø)
Lib/modulefinder.py 67.44% <0.00%> (ø)
Lib/distutils/tests/support.py 85.00% <0.00%> (ø)
Lib/email/mime/base.py 100.00% <0.00%> (ø)
Lib/tkinter/test/test_ttk/test_widgets.py 97.43% <0.00%> (ø)
Lib/importlib/abc.py 93.44% <0.00%> (ø)
Lib/test/test_property.py 90.32% <0.00%> (ø)
Lib/test/test_importlib/test_open.py 95.23% <0.00%> (ø)
Lib/unittest/test/testmock/support.py 87.50% <0.00%> (ø)
... and 1564 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f632736...79b5e0b. Read the comment docs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10
bpo-39473: Update NEWS
79b5e0b
@vstinner
vstinner merged commit 9aeb0ef into python:master Feb 14, 2020
@bedevere-bot bedevere-bot removed the awaiting review label Feb 14, 2020
@vstinner

vstinner commented Feb 14, 2020

Copy link
Copy Markdown
Member

Merged, thanks. I just replace "macro" with "function" in the commit message :-)
corona10 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request Mar 12, 2024
[C API] Avoid accessing PyObject and PyVarObject members directly: add Py_SET_TYPE() and Py_IS_TYPE(), disallow Py_TYPE(obj)=type #83754
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner Awaiting requested review from vstinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@corona10 @vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.