GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — bpo-39573: Clean up modules and headers to use Py_IS_TYPE by corona10 · Pull Request #18521 · python/cpython

Conversation

corona10 commented Feb 16, 2020 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

https://bugs.python.org/issue39573

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          bpo-39573: Clean up modules and headers to use Py_IS_TYPE

cea3179

corona10 requested review from 1st1, abalkin, asvetlov, methane, pganssle, rhettinger, skrah and tiran as code owners

February 16, 2020 17:25

the-knights-who-say-ni added the CLA signed label

Feb 16, 2020

bedevere-bot added the awaiting review label

Feb 16, 2020

corona10 added the skip news label

Feb 16, 2020

corona10 removed request for 1st1, abalkin, asvetlov, methane, pganssle, rhettinger, skrah and tiran

February 16, 2020 17:25


          bpo-39573: Lint

2c4ce0f

corona10 requested a review from vstinner

February 16, 2020 17:30

vstinner requested changes

Feb 17, 2020

View reviewed changes

vstinner left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use git rebase, just add a commit, to ease review ;-) This PR is long to review.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Objects/typeobject.c Outdated

		*/
		Py_ssize_t i, n;
		int custom = (Py_TYPE(type) != &PyType_Type);
		int custom = Py_IS_TYPE(type, &PyType_Type);

vstinner Feb 17, 2020

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one looks wrong.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

corona10 Feb 17, 2020

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh.. good catch!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vstinner Feb 17, 2020

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that you made this mistake on purpose. Just to check that I really review your PRs! :-)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

corona10 Feb 17, 2020

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot removed the awaiting review label

Feb 17, 2020

bedevere-bot commented Feb 17, 2020

Copy link

Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added the awaiting changes label

Feb 17, 2020


          bpo-39573: Fix mistake

99ed0fd

vstinner approved these changes

Feb 17, 2020

View reviewed changes

vstinner left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot added awaiting merge and removed awaiting changes labels

Feb 17, 2020

vstinner merged commit 1b55b65 into python:master

Feb 17, 2020

bedevere-bot removed the awaiting merge label

Feb 17, 2020

vstinner mentioned this pull request

Mar 12, 2024

[C API] Avoid accessing PyObject and PyVarObject members directly: add Py_SET_TYPE() and Py_IS_TYPE(), disallow Py_TYPE(obj)=type #83754

Closed

Reviewers

vstinner

vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

corona10 commented Feb 16, 2020 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

vstinner Feb 17, 2020

Choose a reason for hiding this comment

Uh oh!

corona10 Feb 17, 2020

Choose a reason for hiding this comment

Uh oh!

vstinner Feb 17, 2020

Choose a reason for hiding this comment

Uh oh!

corona10 Feb 17, 2020

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented Feb 17, 2020

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

corona10 commented Feb 16, 2020 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.