GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-64490: varargs support for argument clinic and refactor print with AC by isidentical · Pull Request #18609 · python/cpython

Conversation

isidentical commented Feb 22, 2020 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

f(*args, /)
f(x, y, *args, /)
f(*args)
f(x, y, *args)
f(x, /, y, *args)
f(x, *args, y=3)
f(*args, y=3, z=5)

https://bugs.python.org/issue20291

Issue: Argument Clinic should understand *args and **kwargs parameters #64490

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

the-knights-who-say-ni added the CLA signed label

Feb 22, 2020

bedevere-bot added the awaiting review label

Feb 22, 2020

isidentical added DO-NOT-MERGE skip issue skip news labels

Feb 22, 2020

isidentical force-pushed the bpo-20291 branch from 169a88a to 10a983e Compare

February 23, 2020 10:13

isidentical changed the title ~~[WIP] varargs support for argument clinic~~ [WIP] varargs support for argument clinic and refactor print with AC

Feb 23, 2020

isidentical force-pushed the bpo-20291 branch 4 times, most recently from 8dca07a to 239ad97 Compare

February 24, 2020 17:07

isidentical changed the title ~~[WIP] varargs support for argument clinic and refactor print with AC~~ [WIP] bpo-20291: varargs support for argument clinic and refactor print with AC

Feb 24, 2020

isidentical removed the skip issue label

Feb 24, 2020

isidentical force-pushed the bpo-20291 branch 5 times, most recently from 0ae57a2 to deef95c Compare

February 26, 2020 12:31

codecov Bot commented Feb 26, 2020

Copy link

Copy Markdown

Codecov Report

Merging #18609 into master will increase coverage by 1.12%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #18609       +/-   ##
===========================================
+ Coverage   82.08%   83.20%    +1.12%     
===========================================
  Files        1956     1571      -385     
  Lines      589394   414936   -174458     
  Branches    44457    44482       +25     
===========================================
- Hits       483778   345267   -138511     
+ Misses      95969    60023    -35946     
+ Partials     9647     9646        -1

Impacted Files	Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py	`30.00% <0.00%> (-65.00%)`	⬇️
Lib/distutils/command/bdist_rpm.py	`7.63% <0.00%> (-56.88%)`	⬇️
Lib/test/test_urllib2net.py	`76.92% <0.00%> (-13.85%)`	⬇️
Lib/test/test_smtpnet.py	`78.57% <0.00%> (-7.15%)`	⬇️
Lib/ftplib.py	`63.85% <0.00%> (-6.06%)`	⬇️
Lib/test/test_ftplib.py	`87.11% <0.00%> (-4.72%)`	⬇️
Tools/scripts/db2pickle.py	`17.82% <0.00%> (-3.97%)`	⬇️
Tools/scripts/pickle2db.py	`16.98% <0.00%> (-3.78%)`	⬇️
Lib/test/test_socket.py	`71.94% <0.00%> (-3.77%)`	⬇️
Lib/test/test_asyncio/test_base_events.py	`91.84% <0.00%> (-3.30%)`	⬇️
... and 446 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dee92b...deef95c. Read the comment docs.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

isidentical marked this pull request as ready for review

February 26, 2020 16:08

isidentical changed the title ~~[WIP] bpo-20291: varargs support for argument clinic and refactor print with AC~~ bpo-20291: varargs support for argument clinic and refactor print with AC

Feb 26, 2020

isidentical removed DO-NOT-MERGE skip news labels

Feb 26, 2020

serhiy-storchaka self-requested a review

March 14, 2020 10:23

serhiy-storchaka reviewed

Mar 14, 2020

View reviewed changes

serhiy-storchaka left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting PR. Thank you that taken this issue Batuhan! 👍 But it will take a time to make a review.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Misc/NEWS.d/next/Tools-Demos/2020-02-25-18-22-09.bpo-20291.AyrDiZ.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Python/bltinmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Python/bltinmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Python/bltinmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Python/bltinmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Python/bltinmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Include/modsupport.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka added the type-feature A feature request or enhancement label

Mar 14, 2020

isidentical force-pushed the bpo-20291 branch from 85fea0e to a9ffdcb Compare

March 15, 2020 03:51

isidentical force-pushed the bpo-20291 branch from a9ffdcb to 445eaa5 Compare

September 3, 2020 16:10

isidentical requested a review from larryhastings

October 21, 2020 13:06

isidentical force-pushed the bpo-20291 branch from 445eaa5 to 7946d47 Compare

June 2, 2021 20:02

isidentical force-pushed the bpo-20291 branch from 7946d47 to cd8c017 Compare

June 2, 2021 20:21

pablogsal commented Jun 3, 2021

Copy link

Copy Markdown

Member

@serhiy-storchaka Could you review this PR if you have the time? If you are busy I can finish the review myself and try to land it so it reaches 3.11 :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

pablogsal commented Jul 13, 2021

Copy link

Copy Markdown

Member

@isidentical Can you rebase this and we can land it?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          bpo-20201: varargs support for argument clinic and refactor print wit…

…h AC

isidentical force-pushed the bpo-20291 branch from cd8c017 to 4186327 Compare

July 13, 2021 15:24

isidentical added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label

Jul 13, 2021

bedevere-bot commented Jul 13, 2021

Copy link

Copy Markdown

🤖 New build scheduled with the buildbot fleet by @isidentical for commit 4186327 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label

Jul 13, 2021

pablogsal approved these changes

Jul 13, 2021

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels

Jul 13, 2021

pablogsal commented Jul 13, 2021

Copy link

Copy Markdown

Member

@isidentical Land if the buildbots are happy. Don't forget to also change the docs for the argument clinic in the devguide with any updates!

isidentical reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

isidentical merged commit 9af34c9 into python:main

Jul 16, 2021

bedevere-bot removed the awaiting merge label

Jul 16, 2021

sweeneyde mentioned this pull request

Dec 31, 2021

gh-90350: Optimize builtin functions min() and max() #30286

Merged

colorfulappl mentioned this pull request

Mar 24, 2022

gh-64490: Fix bugs in argument clinic varargs processing #32092

Merged

larryhastings mentioned this pull request

Apr 10, 2022

Argument Clinic should understand *args and **kwargs parameters #64490

Closed

gpshead changed the title ~~bpo-20291: varargs support for argument clinic and refactor print with AC~~ gh-64490: varargs support for argument clinic and refactor print with AC

Feb 7, 2023

gpshead commented Feb 7, 2023

Copy link

Copy Markdown

Member

The Doc/howto/clinic.rst docs still need updating.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

serhiy-storchaka

serhiy-storchaka left review comments

pablogsal

pablogsal approved these changes

larryhastings

Awaiting requested review from larryhastings

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-feature

A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

isidentical commented Feb 22, 2020 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Feb 26, 2020

Codecov Report

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pablogsal commented Jun 3, 2021

Uh oh!

pablogsal commented Jul 13, 2021

Uh oh!

bedevere-bot commented Jul 13, 2021

Uh oh!

pablogsal commented Jul 13, 2021

Uh oh!

gpshead commented Feb 7, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

isidentical commented Feb 22, 2020 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.