GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-74699: test_pop3lib asyncore with asyncio by grzgrzgrz3 · Pull Request #1864 · python/cpython

Conversation

grzgrzgrz3 commented May 30, 2017 •

edited by serhiy-storchaka

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Pop3 server stub was base on asyncore/asynchat which is deprecated, new
stub is using asyncio instead.

test_too_long_lines make sure we read remaining overlong response

cmd_user answer only with +ERR message on invalid user

#74699

Issue: test_poplib replace asyncore #74699

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          bpo-30514: test_pop3lib asyncore with asyncio

db49288

Pop3 server stub was base on asyncore/asynchat which is deprecated, new
stub is using asyncio instead.

test_too_long_lines make sure we read remaining overlong response

cmd_user answer only with +ERR message on invalid user

the-knights-who-say-ni added the CLA signed label

May 30, 2017

mention-bot commented May 30, 2017

Copy link

Copy Markdown

@grzgrzgrz3, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tiran, @serhiy-storchaka and @giampaolo to be potential reviewers.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Teardown tests correctly

996e0cc

codecov Bot commented May 30, 2017

Copy link

Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@9c972b5). Click here to learn what that means.
The diff coverage is 97.67%.

@@            Coverage Diff            @@
##             master    #1864   +/-   ##
=========================================
  Coverage          ?   82.68%           
=========================================
  Files             ?     1432           
  Lines             ?   353405           
  Branches          ?        0           
=========================================
  Hits              ?   292229           
  Misses            ?    61176           
  Partials          ?        0

Impacted Files	Coverage Δ
Lib/test/test_poplib.py	`98.13% <97.67%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c972b5...996e0cc. Read the comment docs.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Mariatta added needs rebase and removed needs rebase labels

Oct 9, 2017

brettcannon added the awaiting review label

Feb 2, 2018

serhiy-storchaka added the tests Tests in the Lib/test dir label

Dec 8, 2018

matrixise self-assigned this

Sep 12, 2019

auvipy suggested changes

Jul 20, 2021

View reviewed changes

auvipy left a comment

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a rebase on top of main branch would be a good first start

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot added awaiting core review and removed awaiting review labels

Jul 20, 2021

matrixise removed their assignment

Oct 5, 2021

github-actions Bot commented Feb 19, 2022

Copy link

Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot added the stale Stale PR or inactive for long period of time. label

Feb 19, 2022

AlexWaygood added the topic-asyncio label

Apr 11, 2022

grzgrzgrz3 mannequin mentioned this pull request

Apr 11, 2022

test_poplib replace asyncore #74699

Closed

JelleZijlstra self-assigned this

May 10, 2022

JelleZijlstra commented May 10, 2022

Copy link

Copy Markdown

Member

I'll work on getting this up to date so it unblocks removing asyncore. Note to self: local branch name is bpo30514-grzegorz-grzywacz-poplib.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot removed the stale Stale PR or inactive for long period of time. label

May 11, 2022

JelleZijlstra mentioned this pull request

May 26, 2022

tests still rely on the removed stdlib modules asyncore/asynchat #93243

Closed

2 of 12 tasks

AA-Turner commented Jun 7, 2022

Copy link

Copy Markdown

Member

Triggering CLA.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AA-Turner closed this

Jun 7, 2022

AA-Turner reopened this

Jun 7, 2022

AA-Turner removed the CLA signed label

Jun 7, 2022

github-actions Bot commented Jul 8, 2022

Copy link

Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot added the stale Stale PR or inactive for long period of time. label

Jul 8, 2022

kumaraditya303 removed the topic-asyncio label

Oct 9, 2022

github-actions Bot removed the stale Stale PR or inactive for long period of time. label

Oct 10, 2022

github-actions Bot commented Nov 10, 2022

Copy link

Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot added the stale Stale PR or inactive for long period of time. label

Nov 10, 2022

JelleZijlstra removed their assignment

Nov 12, 2022

github-actions Bot removed the stale Stale PR or inactive for long period of time. label

Nov 13, 2022

github-actions Bot commented Dec 14, 2022

Copy link

Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot added the stale Stale PR or inactive for long period of time. label

Dec 14, 2022

serhiy-storchaka changed the title ~~bpo-30514: test_pop3lib asyncore with asyncio~~ gh-74699: test_pop3lib asyncore with asyncio

Aug 12, 2026

github-actions Bot removed the stale Stale PR or inactive for long period of time. label

Aug 13, 2026

ambv commented Oct 22, 2026

Copy link

Copy Markdown

Contributor

This PR is obsolete: it was written against 2017 asyncio APIs that no longer exist, and main now tests poplib with vendored test.support asyncore/asynchat. Closing to cull the number of open pull requests. Do not reopen this pull request without getting a go-ahead from a triager or core developer on gh-74699.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ambv closed this

Oct 22, 2026

Reviewers

1 more reviewer

auvipy

auvipy requested changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review tests

Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

14 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

grzgrzgrz3 commented May 30, 2017 • edited by serhiy-storchaka Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mention-bot commented May 30, 2017

Uh oh!

codecov Bot commented May 30, 2017

Codecov Report

Uh oh!

auvipy left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Feb 19, 2022

Uh oh!

JelleZijlstra commented May 10, 2022

Uh oh!

AA-Turner commented Jun 7, 2022

Uh oh!

github-actions Bot commented Jul 8, 2022

Uh oh!

github-actions Bot commented Nov 10, 2022

Uh oh!

github-actions Bot commented Dec 14, 2022

Uh oh!

ambv commented Oct 22, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

grzgrzgrz3 commented May 30, 2017 •

edited by serhiy-storchaka

Loading

Uh oh!

There was an error while loading. Please reload this page.