GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-39757: Use IDNA to encode domain part in email address by Julien00859 · Pull Request #18667 · python/cpython

Conversation

@Julien00859

@Julien00859 Julien00859 commented Feb 26, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

While b64/qp can be used to encode most non-ascii headers, the domain
part of an email address must conform IDNA (rfc5890, rfc5891) thus
be encoded using the punycode algorithm (rfc3492).

https://bugs.python.org/issue39757

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Julien00859
Julien00859 requested a review from a team as a code owner February 26, 2020 10:30
@the-knights-who-say-ni

the-knights-who-say-ni commented Feb 26, 2020

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@Julien00859

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label Feb 26, 2020
@bedevere-bot bedevere-bot added the awaiting review label Feb 26, 2020
@Julien00859

Julien00859 commented Feb 26, 2020

Copy link
Copy Markdown
Author

CLA was signed this morning, also is it possible to mark this one to be backported in 3.8 and 3.7 ?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Julien00859
bpo-39757: Use IDNA to encode domain part in email address
dccf01a 
While b64/qp can be used to encode most non-ascii headers, the domain
part of an email address must conform IDNA ([rfc5890], [rfc5891]) thus
be encoded using the punycode algorithm ([rfc3492]). [SMTPUTF8](rfc6531)
is no exception.

[rfc5890]: https://tools.ietf.org/html/rfc5890
[rfc5891]: https://tools.ietf.org/html/rfc5891
[rfc3492]: https://tools.ietf.org/html/rfc3492
[rfc6531]: https://tools.ietf.org/html/rfc6531#section-3.2
@Julien00859
Julien00859 force-pushed the fix-bpo-39757 branch from d79eb72 to dccf01a Compare February 26, 2020 15:41
@blurb-it
📜🤖 Added by blurb_it.
12d60ed
@the-knights-who-say-ni the-knights-who-say-ni added CLA signed and removed CLA not signed labels Feb 27, 2020
@Julien00859

Julien00859 commented Feb 27, 2020

Copy link
Copy Markdown
Author

Duplicate of https://bugs.python.org/issue11783
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Julien00859 Julien00859 closed this Feb 27, 2020
@Julien00859
Julien00859 deleted the fix-bpo-39757 branch February 27, 2020 14:17
@Julien00859 Julien00859 mannequin mentioned this pull request Nov 23, 2023
EmailMessage bad encoding for international domain #83938
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Julien00859 @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.