GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-39877: take_gil() checks tstate_must_exit() twice by vstinner · Pull Request #18888 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Mar 9, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

take_gil() now also checks tstate_must_exit() after acquiring the
GIL: exit the thread if Py_Finalize() has been called.

https://bugs.python.org/issue39877

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
bpo-39877: take_gil() checks tstate_must_exit() twice
976b2ce 
take_gil() now also checks tstate_must_exit() after acquiring the
GIL: exit the thread if Py_Finalize() has been called.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 9, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Mar 9, 2020
@vstinner vstinner added the skip news label Mar 9, 2020
@vstinner vstinner closed this Mar 9, 2020
@vstinner vstinner reopened this Mar 9, 2020
@vstinner

vstinner commented Mar 9, 2020

Copy link
Copy Markdown
Member Author

GH Actions CI is broken. I cancelled the workflow. It didn't work. I closed/reopened the PR: GH Actions jobs are still displayed as failed and don't restart.

I created a new PR instead: PR #18890.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Mar 9, 2020

Copy link
Copy Markdown
Member Author

I created a new PR instead: PR #18890.

I merged PR #18890.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner closed this Mar 9, 2020
@vstinner
vstinner deleted the take_gil_exit2 branch March 9, 2020 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.