GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.8] bpo-38576: Disallow control characters in hostnames in http.client (GH-18995) by miss-islington · Pull Request #19000 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Mar 14, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Add host validation for control characters for more CVE-2019-18348 protection.
(cherry picked from commit 9165add)

Co-authored-by: Ashwin Ramaswami [email protected]

https://bugs.python.org/issue38576

Automerge-Triggered-By: @gpshead

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@epicfaace @miss-islington
bpo-38576: Disallow control characters in hostnames in http.client (p…
f8213f0 
…ythonGH-18995)

Add host validation for control characters for more CVE-2019-18348 protection.
(cherry picked from commit 9165add)

Co-authored-by: Ashwin Ramaswami <[email protected]>
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 14, 2020
@bedevere-bot bedevere-bot mentioned this pull request Mar 14, 2020
bpo-38576: Disallow control characters in hostnames in http.client #18995
Merged
@bedevere-bot bedevere-bot added type-bug An unexpected behavior, bug, or error type-security A security issue awaiting review labels Mar 14, 2020
@gpshead gpshead added the 🤖 automerge label Mar 14, 2020
gpshead
gpshead approved these changes Mar 14, 2020
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Mar 14, 2020
@miss-islington

miss-islington commented Mar 14, 2020

Copy link
Copy Markdown
Contributor Author

@epicfaace and @gpshead: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit ff69c9d into python:3.8 Mar 14, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 14, 2020
@miss-islington
miss-islington deleted the backport-9165add-3.8 branch March 14, 2020 19:13
@miss-islington

miss-islington commented Mar 14, 2020

Copy link
Copy Markdown
Contributor Author

@epicfaace and @gpshead: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1 similar comment
@miss-islington

miss-islington commented Mar 14, 2020

Copy link
Copy Markdown
Contributor Author

@epicfaace and @gpshead: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @gpshead @the-knights-who-say-ni @bedevere-bot @epicfaace
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.