GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-1635741: Port itertools module to multiphase initialization. by corona10 · Pull Request #19044 · python/cpython

Conversation

@corona10

@corona10 corona10 commented Mar 17, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue1635741

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10
corona10 requested a review from rhettinger as a code owner March 17, 2020 15:18
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 17, 2020
@bedevere-bot bedevere-bot added the awaiting review label Mar 17, 2020
@corona10
corona10 force-pushed the bpo-1635741-itertools branch from 223b1c0 to ce22af3 Compare March 17, 2020 15:28
@corona10
bpo-1635741: Port itertools module to multiphase initialization.
6980d78
@corona10
corona10 force-pushed the bpo-1635741-itertools branch from ce22af3 to 6980d78 Compare March 17, 2020 15:32
@corona10
corona10 requested a review from vstinner March 17, 2020 16:11
@corona10

corona10 commented Mar 17, 2020

Copy link
Copy Markdown
Member Author

@shihai1991 Can you please take a look?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner approved these changes Mar 17, 2020
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I will wait for @shihai1991 review ;-)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
corona10 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread Modules/itertoolsmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Mar 17, 2020
corona10 added 2 commits March 18, 2020 01:59
@corona10
bpo-1635741: Apply Victor's review
ab0ef4e
@corona10
bpo-1635741: nit
b5f113f
vstinner
vstinner reviewed Mar 17, 2020
View reviewed changes
Comment thread Modules/itertoolsmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
Update Modules/itertoolsmodule.c
ff90880
@vstinner

vstinner commented Mar 17, 2020

Copy link
Copy Markdown
Member

You forgot a typelist[i], I fixed it ;-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
shihai1991
shihai1991 approved these changes Mar 17, 2020
View reviewed changes

@shihai1991 shihai1991 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ;)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
corona10 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@corona10

corona10 commented Mar 17, 2020

Copy link
Copy Markdown
Member Author

You forgot a typelist[i], I fixed it ;-)

Thanks :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@shihai1991

shihai1991 commented Mar 17, 2020

Copy link
Copy Markdown
Member

there is one thing to be confirmed: race condition of identifier in typelists can be avoid too? no potential risk?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10

corona10 commented Mar 17, 2020

Copy link
Copy Markdown
Member Author

there is one thing to be confirmed: race condition of identifier in typelists can be avoid too? no potential risk?

Can you explain more concrete situation?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Mar 17, 2020

Copy link
Copy Markdown
Member

there is one thing to be confirmed: race condition of identifier in typelists can be avoid too? no potential risk?

Currently, the GIL magically protects C extensions against race conditions. But the GIL can be released when executing arbitrary code. I don't think that it's the case here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Mar 17, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Static types initialized by PyType_Ready() are bad. Types allocated on the heap using PyType_FromSpec() are better:
https://pythoncapi.readthedocs.io/type_object.html

But this should be addressed in a separated change ;-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 514c469 into python:master Mar 17, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 17, 2020
@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Py_Finalize() doesn't clear all Python objects at exit #44470
Closed
@corona10
corona10 deleted the bpo-1635741-itertools branch February 15, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@shihai1991 shihai1991 shihai1991 approved these changes
@rhettinger rhettinger Awaiting requested review from rhettinger

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@corona10 @vstinner @shihai1991 @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.