GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [WIP] bpo-38865: Py_FinalizeEx() cannot be called in a subinterpreter by vstinner · Pull Request #19063 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Mar 18, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Py_FinalizeEx() cannot be called in a subinterpreter anymore.

Fix test_embed.test_audit_subinterpreter(): end subinterpreters.

https://bugs.python.org/issue38865

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
bpo-38865: Py_FinalizeEx() cannot be called in a subinterpreter
21d563c 
Py_FinalizeEx() cannot be called in a subinterpreter anymore.

Fix test_embed.test_audit_subinterpreter(): end subinterpreters.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 18, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Mar 18, 2020
@vstinner

vstinner commented Mar 19, 2020

Copy link
Copy Markdown
Member Author

Hum. I had issues while writing PR #19066, but in the pubilished PR, it seems like modifying Py_FinalizeEx() is no longer needed.

I change the PR state to WIP / do-not-merged until I completly understand the issue and ensures that Py_FinalizeEx() behavior must change.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner added the DO-NOT-MERGE label Mar 19, 2020
@vstinner vstinner changed the title bpo-38865: Py_FinalizeEx() cannot be called in a subinterpreter [WIP] bpo-38865: Py_FinalizeEx() cannot be called in a subinterpreter Mar 19, 2020
@vstinner

vstinner commented Mar 20, 2020

Copy link
Copy Markdown
Member Author

I managed to implement https://bugs.python.org/issue39984 without needing this PR, so I close it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner closed this Mar 20, 2020
@vstinner
vstinner deleted the finalize_subinterp branch March 20, 2020 16:00
@LewisGaul LewisGaul mentioned this pull request Oct 20, 2020
gh-80406: Finalise subinterpreters in Py_FinalizeEx() #17575
Closed
@vstinner vstinner mentioned this pull request Apr 10, 2022
[subinterpreters] Can Py_Finalize() be called if the current interpreter is not the main interpreter? #83046
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review DO-NOT-MERGE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.