GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [WIP] bpo-1635741: Port _collections module to multiphase initialization. by corona10 · Pull Request #19071 · python/cpython

Conversation

@corona10

@corona10 corona10 commented Mar 19, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue1635741

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10
corona10 requested a review from rhettinger as a code owner March 19, 2020 14:35
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 19, 2020
@bedevere-bot bedevere-bot added the awaiting review label Mar 19, 2020
corona10
corona10 commented Mar 19, 2020
View reviewed changes
Comment thread Modules/_collectionsmodule.c Outdated

@corona10 corona10 Mar 19, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vstinner I'd like to create a new helper function for this.

This logic can be reused.
https://github.com/python/cpython/blob/514c469719f149e1722a91a9d0c63bf89dfefb2a/Modules/itertoolsmodule.c#L4733L4747

What do you think?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@vstinner vstinner Mar 19, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean combine PyType_Ready + _PyType_Name + PyModule_AddObject? Yeah, maybe it's worth it, but I would prefer to add it once this PR lands.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10 corona10 added the DO-NOT-MERGE label Mar 19, 2020
@corona10 corona10 changed the title bpo-1635741: Port _collections module to multiphase initialization. [WIP] bpo-1635741: Port _collections module to multiphase initialization. Mar 19, 2020
@corona10
bpo-1635741: Port _collections module to multiphase initialization.
fb35d81
@corona10
corona10 force-pushed the bpo-1635741-_collectionsmodule branch from 58e7344 to fb35d81 Compare March 19, 2020 14:46
vstinner
vstinner reviewed Mar 19, 2020
View reviewed changes
Comment thread Modules/_collectionsmodule.c
&PyODict_Type,
&dequeiter_type,
&dequereviter_type,
&tuplegetter_type,

@vstinner vstinner Mar 19, 2020

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either you use Py_ARRAY_COUNT() to get the list length, or you need to add a NULL terminator. Currently, you rely on an undefined behavior.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10 corona10 closed this Mar 19, 2020
@corona10 corona10 mentioned this pull request Mar 19, 2020
bpo-1635741: Port _collections module to multiphase initialization. #19074
Merged
@shihai1991

shihai1991 commented Mar 19, 2020

Copy link
Copy Markdown
Member

FWIW, some comments in https://github.com/python/cpython/pull/18066/files
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Py_Finalize() doesn't clear all Python objects at exit #44470
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments
@rhettinger rhettinger Awaiting requested review from rhettinger

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review DO-NOT-MERGE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@corona10 @shihai1991 @vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.