GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-1635741: Enhance get_binascii_state() by shihai1991 · Pull Request #19100 · python/cpython

Conversation

@shihai1991

@shihai1991 shihai1991 commented Mar 21, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue1635741

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@shihai1991
Enhance get_binascii_module()
fc0e683
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 21, 2020
@bedevere-bot bedevere-bot added the awaiting review label Mar 21, 2020
@shihai1991 shihai1991 changed the title bpo-1635741: Enhance get_binascii_module() bpo-1635741: Enhance get_binascii_state() Mar 22, 2020
corona10
corona10 reviewed Mar 24, 2020
View reviewed changes

@corona10 corona10 left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10 corona10 added the skip news label Mar 24, 2020
@corona10

corona10 commented Mar 24, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Looks like _Pickle_GetState needs same change on sperate PR..

cpython/Modules/_pickle.c

Line 183 in dffe4c0

_Pickle_GetState(PyObject *module)

shihai1991 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@shihai1991

shihai1991 commented Mar 25, 2020

Copy link
Copy Markdown
Member Author

Looks like _Pickle_GetState needs same change on sperate PR..

cpython/Modules/_pickle.c

Line 183 in dffe4c0

_Pickle_GetState(PyObject *module)

I create this sperate change due to binascii extension module have been ported to pep-489.
IMO, other extension modules' get_xxx_state() can be done with porting operation.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@shihai1991

shihai1991 commented Mar 26, 2020

Copy link
Copy Markdown
Member Author

cc @vstinner Hi, victor. It's a enhancement operation of binascii's get_module_state()
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Mar 26, 2020

Copy link
Copy Markdown
Member

I don't think that this change is worth it. In practice, I don't see why the state would be NULL. If it's the case, the code should crash anyway :-) Existing code which checks that the state is not NULL with an assertion is fine. But I don't think that this change is worth it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner closed this Mar 26, 2020
@shihai1991

shihai1991 commented Mar 26, 2020

Copy link
Copy Markdown
Member Author

got it, thanks, victor :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Py_Finalize() doesn't clear all Python objects at exit #44470
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@shihai1991 @corona10 @vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.