GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-1635741: Port resource extension module to multiphase initialization(PEP 489) by shihai1991 · Pull Request #19252 · python/cpython

Conversation

@shihai1991

@shihai1991 shihai1991 commented Mar 31, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue1635741

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@shihai1991
Port resource extension module to multiphase initialization(PEP 489)
274da20
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 31, 2020
@bedevere-bot bedevere-bot added the awaiting review label Mar 31, 2020
corona10
corona10 reviewed Mar 31, 2020
View reviewed changes
Comment thread Modules/resource.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
corona10
corona10 reviewed Mar 31, 2020
View reviewed changes
Comment thread Misc/NEWS.d/next/Core and Builtins/2020-04-01-00-08-18.bpo-1635741.bhGWam.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
corona10
corona10 reviewed Mar 31, 2020
View reviewed changes
Comment thread Modules/resource.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@corona10

corona10 commented Mar 31, 2020

Copy link
Copy Markdown
Member

@shihai1991 Thanks for the contribution :) I left some comments for you
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
corona10
corona10 reviewed Mar 31, 2020
View reviewed changes
Comment thread Modules/resource.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/resource.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@shihai1991
update code
6b46c86
corona10
corona10 approved these changes Apr 1, 2020
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10
corona10 requested a review from vstinner April 1, 2020 02:05
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Apr 1, 2020
vstinner
vstinner requested changes Apr 1, 2020
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conversion to multiphase init is correct, but I would like to take the opportunity of this refactoring to fix error handling.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Modules/resource.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/resource.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/resource.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting changes and removed awaiting core review labels Apr 1, 2020
@bedevere-bot

bedevere-bot commented Apr 1, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@shihai1991
fix some potential refleaks
90504f7
@vstinner

vstinner commented Apr 1, 2020

Copy link
Copy Markdown
Member

The macOS job failed because of https://bugs.python.org/issue40144
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner reviewed Apr 1, 2020
View reviewed changes
Comment thread Modules/resource.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/resource.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
shihai1991 added 2 commits April 2, 2020 13:16
@shihai1991
Simplify the code
7a82976
@shihai1991
remove file's ADD_INT macro
a0dcd68
@vstinner

vstinner commented Apr 2, 2020

Copy link
Copy Markdown
Member

The macOS job failed, see: https://bugs.python.org/issue40144
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner reviewed Apr 2, 2020
View reviewed changes
Comment thread Modules/resource.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/resource.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/resource.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
shihai1991 added 2 commits April 2, 2020 19:29
@shihai1991
Use PyModule_AddIntConstant to replace PyModule_AddIntMacro
7add9ba
@shihai1991
move position of claim of v
41d6bf8
vstinner
vstinner approved these changes Apr 2, 2020
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please fix coding style issues.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Modules/resource.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/resource.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/resource.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting changes labels Apr 2, 2020
@shihai1991
Fix style issues
6fdb19a
@vstinner

vstinner commented Apr 2, 2020

Copy link
Copy Markdown
Member

macOS is back to green, great ;-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 45f7008 into python:master Apr 2, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 2, 2020
@vstinner

vstinner commented Apr 2, 2020

Copy link
Copy Markdown
Member

Thanks. I completed the commit message to mention refleak fixes.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@shihai1991

shihai1991 commented Apr 2, 2020

Copy link
Copy Markdown
Member Author

Thanks. I completed the commit message to mention refleak fixes.

Got it, thanks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Py_Finalize() doesn't clear all Python objects at exit #44470
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@corona10 corona10 corona10 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@shihai1991 @corona10 @bedevere-bot @vstinner @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.