GeezerVison

@segevfiner, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zooba, @benjaminp and @serhiy-storchaka to be potential reviewers.

Most of the reference leaks are due to initializing decodedname = Py_None followed by Py_INCREF(decodedname). It should be initialized as NULL.

Some of the reported ref leaks are from calling getwindowsversion in test_conout_path. This call can be moved out of the test by using a global variable, or by splitting the test up like this:

def conout_path_test(self, dos_device):
    temp_path = tempfile.mkdtemp()
    self.addCleanup(support.rmtree, temp_path)
    conout_path = os.path.join(temp_path, 'CONOUT$')

    with open(conout_path, 'wb', buffering=0) as f:
        if dos_device:
            self.assertIsInstance(f, ConIO)
        else:
            self.assertNotIsInstance(f, ConIO)

@unittest.skipIf(sys.getwindowsversion()[:2] <= (6, 1),
    "Windows 7 and earlier resolve CONOUT$ in a directory as a disk file")
def test_conout_path_device(self):
    self.conout_path_test(dos_device=True)

@unittest.skipIf(sys.getwindowsversion()[:2] > (6, 1),
    "Windows 8 and later resolve CONOUT$ in a directory as a DOS device")
def test_conout_path_file(self):
    self.conout_path_test(dos_device=False)

@eryksun So the leaks are real than, nice find! 😄 I can submit a PR/issue with your suggested fix if it helps you or just leave it to you. Why would calling sys.getwindowsversion in a test function leak though? Does that function leak? Or is there something else at play?

EDIT: I can also apply your fix right here if you wish me to.

It should be ok to fix the _WindowsConsoleIO leak and rewrite the test in this issue. The ref leak in getwindowsversion needs a new issue. If you want to work on it, the problem is that it calls PyTuple_Pack directly on the int objects created from realMajor, etc. PyTuple_Pack increments the ref count of each object instead of stealing it.

Merged from master since @Haypo fixed the ref leak separately in #2003.

Merged from master due to argument clinic changes.

Thanks for persisting with this, and sorry for taking so long! Let's put it in and deal with any fallout in 3.10 before backporting.

Thanks @segevfiner for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

Thanks @segevfiner for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

Sorry, @segevfiner and @zooba, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 5e437fb872279960992c9a07f1a4c051b4948c53 3.9

Sorry @segevfiner and @zooba, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 5e437fb872279960992c9a07f1a4c051b4948c53 3.8

Thanks @segevfiner for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

Thanks @segevfiner for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

Sorry, @segevfiner and @zooba, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 5e437fb872279960992c9a07f1a4c051b4948c53 3.9

Sorry @segevfiner and @zooba, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 5e437fb872279960992c9a07f1a4c051b4948c53 3.8