GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-1635741: Enhance PyModule_AddIntMacro by ADD_INT macro by shihai1991 · Pull Request #19307 · python/cpython

Conversation

@shihai1991

@shihai1991 shihai1991 commented Apr 2, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue1635741

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@shihai1991
Use ADD_INT macro to replace PyModule_AddIntMacro macro
6fc9589
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 2, 2020
@bedevere-bot bedevere-bot added the awaiting review label Apr 2, 2020
@shihai1991

shihai1991 commented Apr 2, 2020

Copy link
Copy Markdown
Member Author

Just this extension module need ported independently.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@shihai1991

shihai1991 commented Apr 2, 2020

Copy link
Copy Markdown
Member Author

@vstinner @corona10 Hi, folks. pls have a look of this PR if you have free time, thanks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner reviewed Apr 2, 2020
View reviewed changes
Comment thread Modules/_localemodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
Update Modules/_localemodule.c
0b378de
@vstinner vstinner added the skip news label Apr 2, 2020
@vstinner
vstinner merged commit 7a6f3bc into python:master Apr 2, 2020
@bedevere-bot bedevere-bot removed the awaiting review label Apr 2, 2020
@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Py_Finalize() doesn't clear all Python objects at exit #44470
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@shihai1991 @vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.