GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40038: pathlib: remove partial support for preserving accessor when modifying a path by barneygale · Pull Request #19342 · python/cpython

Conversation

@barneygale

@barneygale barneygale commented Apr 3, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Now #18846 has landed, pathlib.Path._init() does nothing useful and can be removed.

A long time ago, _init() helped preserve the current accessor when creating new paths from an existing path (e.g. by calling q = p.resolve()). But this has only ever worked for a small handful of methods, was never documented, and we currently don't support anything other than _NormalAccessor anyway.

More info in the bug report.

https://bugs.python.org/issue40038

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 3, 2020
@bedevere-bot bedevere-bot added the awaiting review label Apr 3, 2020
@barneygale barneygale mentioned this pull request Apr 3, 2020
bpo-39682: make pathlib.Path immutable by removing (undocumented) support for "closing" a path by using it as a context manager #18846
Merged
@pitrou pitrou added the skip news label Apr 17, 2020
@pitrou

pitrou commented Apr 17, 2020

Copy link
Copy Markdown
Member

Could you merge / rebase with git master so that we run CI freshly?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@barneygale
barneygale force-pushed the bpo-40038-pathlib-path-private-init branch from 71e433a to b65d1cc Compare May 29, 2020 00:52
@barneygale

barneygale commented May 29, 2020

Copy link
Copy Markdown
Contributor Author

Rebased. Sorry for long delay.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@barneygale
bpo-40038: pathlib: remove partial support for preserving accessor wh…
ad0ebef 
…en modifying a path
@barneygale
barneygale force-pushed the bpo-40038-pathlib-path-private-init branch from b65d1cc to ad0ebef Compare January 21, 2021 23:32
@barneygale barneygale mentioned this pull request Jan 22, 2021
bpo-39659: Route calls from pathlib.Path to os.getcwd() via the path accessor #18834
Merged
@barneygale

barneygale commented Jan 22, 2021

Copy link
Copy Markdown
Contributor Author

@pitrou this is read for review FYI! Thanks very much
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zooba
zooba merged commit 2219187 into python:master Apr 7, 2021
@bedevere-bot bedevere-bot removed the awaiting review label Apr 7, 2021
@alexdelorenzo alexdelorenzo mentioned this pull request Apr 16, 2021
Python 3.10 alpha 7 introduces new changes to pathlib alexdelorenzo/aiopath#4
Open
@carlmontanari carlmontanari mentioned this pull request May 10, 2021
fix breaking pathlib change in 3.10 beta1 pytest-dev/pyfakefs#594
Merged
@isidentical isidentical mentioned this pull request Jun 14, 2021
cls._from_parts(args, init=False) is broken on 3.10 treeverse/dvc#6164
Closed
@isidentical isidentical mentioned this pull request Dec 13, 2021
Python 3.10 support is broken liormizr/s3path#94
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@barneygale @pitrou @zooba @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.