GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40077: Fix potential refleaks of _json by shihai1991 · Pull Request #19344 · python/cpython

Conversation

@shihai1991

@shihai1991 shihai1991 commented Apr 3, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue40077

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@shihai1991
Fix potential refleaks of _json
363fa0c
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 3, 2020
@bedevere-bot bedevere-bot added the awaiting review label Apr 3, 2020
@shihai1991

shihai1991 commented Apr 3, 2020

Copy link
Copy Markdown
Member Author

@corona10 self.memo of PyScannerObject should be traversed too, right?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Apr 3, 2020

Copy link
Copy Markdown
Member

@pablogsal: Oh, that's an intersting bug. I consider that it should be backported to 3.7 and 3.8.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner approved these changes Apr 3, 2020
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pablogsal: Do you think that a NEWS entry is required for such fix?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Apr 3, 2020
@pablogsal

pablogsal commented Apr 3, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

@pablogsal: Do you think that a NEWS entry is required for such fix?

Yes, as this may fix much more things that just a memory leak. If (unlikely) the memo gets into a ref cycle, some arbitrary set of objects may not be identified as a cycle and the leak will be considerable. This is a user-visible change: a potential leak that they may be experimenting should be no more, being the leak potentially unbounded.

And yes, it should be backported.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal pablogsal added needs backport to 3.7 labels Apr 3, 2020
corona10
corona10 approved these changes Apr 4, 2020
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.memo of PyScannerObject should be traversed too, right?

Nice catch it should be LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
shihai1991 added 2 commits April 4, 2020 12:59
@shihai1991
Add a new netry
6e41793
@shihai1991
update new entry
37abea9
@vstinner
vstinner merged commit b709302 into python:master Apr 4, 2020
@miss-islington

miss-islington commented Apr 4, 2020

Copy link
Copy Markdown
Contributor

Thanks @shihai1991 for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 4, 2020
@miss-islington

miss-islington commented Apr 4, 2020

Copy link
Copy Markdown
Contributor

Sorry, @shihai1991 and @vstinner, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker b709302f3125622986bd458dfb2954fda5e8366d 3.8
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned vstinner Apr 4, 2020
@miss-islington

miss-islington commented Apr 4, 2020

Copy link
Copy Markdown
Contributor

Sorry @shihai1991 and @vstinner, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker b709302f3125622986bd458dfb2954fda5e8366d 3.7
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner added needs backport to 3.8 and removed needs backport to 3.8 labels Apr 4, 2020
@miss-islington

miss-islington commented Apr 4, 2020

Copy link
Copy Markdown
Contributor

Thanks @shihai1991 for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Apr 4, 2020

Copy link
Copy Markdown
Contributor

Sorry, @shihai1991 and @vstinner, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker b709302f3125622986bd458dfb2954fda5e8366d 3.8
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Apr 4, 2020

Copy link
Copy Markdown
Member

@shihai1991: @miss-islington failed to backport automatically the change, there is merge conflict. You can please backport the fix 3.7 and 3.8? You can use cherry_picker or git cherry-pick -x b709302f3125622986bd458dfb2954fda5e8366d. Tell me if you need help for the backport.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10 corona10 mentioned this pull request Jun 27, 2022
Convert static types to heap types: use PyType_FromSpec() #84258
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@corona10 corona10 corona10 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@vstinner vstinner

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@shihai1991 @vstinner @pablogsal @miss-islington @corona10 @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.