GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40170: Remove PyIndex_Check() macro by vstinner · Pull Request #19428 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Apr 8, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Always declare PyIndex_Check() as an opaque function to hide
implementation details: remove PyIndex_Check() macro. The macro
accessed directly the PyTypeObject.tp_as_number member.

https://bugs.python.org/issue40170

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
bpo-40170: Remove PyIndex_Check() macro
c0972ef 
Always declare PyIndex_Check() as an opaque function to hide
implementation details: remove PyIndex_Check() macro. The macro
accessed directly the PyTypeObject.tp_as_number member.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 8, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Apr 8, 2020
@vstinner

vstinner commented Apr 8, 2020

Copy link
Copy Markdown
Member Author

I already modified C files of Python and Objects subdirectories to use a new fast inlined _PyIndex_Check() function in commit a15e260 (GH-19426).

Only the following modules will be impacted by this change:

  • Modules/_ctypes/_ctypes.c
  • Modules/_elementtree.c
  • Modules/_functoolsmodule.c
  • Modules/_sre.c
  • Modules/_struct.c
  • Modules/_testbuffer.c
  • Modules/_xxsubinterpretersmodule.c
  • Modules/arraymodule.c
  • Modules/mmapmodule.c
  • Modules/posixmodule.c

These modules will now call a function rather than inlining the code.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 307b9d0 into python:master Apr 8, 2020
@bedevere-bot bedevere-bot removed the awaiting core review label Apr 8, 2020
@vstinner
vstinner deleted the remove_index_check_macro branch April 8, 2020 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.