GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [WIP] bpo-40275: Add loggingutils in test.support by shihai1991 · Pull Request #19599 · python/cpython

Conversation

@shihai1991

@shihai1991 shihai1991 commented Apr 19, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue40275

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
shihai1991 added 3 commits April 19, 2020 18:33
@shihai1991
Add loggingutils in test.support
9545fba
@shihai1991
Add loggingutils in test.support
f4fd271
@shihai1991
fix conflict
b96db13
@shihai1991
shihai1991 requested a review from vsajip as a code owner April 19, 2020 10:41
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 19, 2020
@bedevere-bot bedevere-bot added the awaiting review label Apr 19, 2020
@shihai1991 shihai1991 changed the title bpo-40275: Add loggingutils in test.support [WIP] bpo-40275: Add loggingutils in test.support Apr 19, 2020
@shihai1991
fix testcases
dc9741b
@tirkarthi

tirkarthi commented Apr 19, 2020

Copy link
Copy Markdown
Member

cc: @serhiy-storchaka . There is also similar work at #19601 .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka

serhiy-storchaka commented Apr 19, 2020

Copy link
Copy Markdown
Member

TestHandler is only used in test_logging. There is no reason to not define it there.

Also, removing import logging from test.support does not help while logging is imported in unittest. #19601 does all necessary to optimize import.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@shihai1991

shihai1991 commented Apr 19, 2020

Copy link
Copy Markdown
Member Author

TestHandler is only used in test_logging. There is no reason to not define it there.

Oh, thanks. I just left a same question in PR19601.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@shihai1991 shihai1991 closed this Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vsajip vsajip Awaiting requested review from vsajip

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@shihai1991 @tirkarthi @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.