GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-34037: Add Python API whatsnew for loop.shutdown_default_executor() by aeros · Pull Request #19634 · python/cpython

Conversation

@aeros

@aeros aeros commented Apr 21, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue34037

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aeros
Add Python API whatsnew for loop.shutdown_default_executor()
8b14536
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 21, 2020
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting core review labels Apr 21, 2020
@aeros aeros added the skip news label Apr 21, 2020
vstinner
vstinner approved these changes Apr 21, 2020
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart the typo ;-)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/whatsnew/3.9.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Apr 21, 2020
@aeros @vstinner
Fix typo
6539f80 
Co-Authored-By: Victor Stinner <[email protected]>
@aeros

aeros commented Apr 21, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Thanks for the review @vstinner. I'll merge it after the CI finishes.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aeros
aeros merged commit 9c82ea7 into python:master Apr 21, 2020
@bedevere-bot

bedevere-bot commented Apr 21, 2020

Copy link
Copy Markdown

@aeros: Please replace # with GH- in the commit message next time. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 21, 2020
@aeros

aeros commented Apr 21, 2020

Copy link
Copy Markdown
Contributor Author

I wanted to try merging via the GitHub "Squash and Merge" instead of with automerge this time. I told myself just a minute ago "remember to change it to GH-", and I still completely forgot, haha.

But, I suppose that's somewhat inevitable as a new core dev, seeing as experienced core devs still manage to forget this step on occasion. :-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aeros
aeros deleted the bpo34037-shutdown_default_executor-api-whatsnew branch April 21, 2020 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@aeros @bedevere-bot @vstinner @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.