GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40334: Fix errors in parse_string.c with old compilers by pablogsal · Pull Request #19666 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented Apr 22, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue40334

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@pablogsal
bpo-40334: Fix errors in parse_string.c with old compilers
3192787
@pablogsal pablogsal added the skip news label Apr 22, 2020
@pablogsal pablogsal self-assigned this Apr 22, 2020
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 22, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Apr 22, 2020
@pablogsal

pablogsal commented Apr 22, 2020

Copy link
Copy Markdown
Member Author

This fixes this buildbot errors:

https://buildbot.python.org/all/#/builders/6/builds/824/steps/5/logs/stdio

/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c: In function ‘fstring_shift_seq_locations’:
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:278:5: error: ‘for’ loop initial declarations are only allowed in C99 mode
     for (Py_ssize_t i = 0, l = asdl_seq_LEN(seq); i < l; i++) {
     ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:278:5: note: use option -std=c99 or -std=gnu99 to compile your code
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c: In function ‘fstring_shift_arguments’:
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:325:5: error: ‘for’ loop initial declarations are only allowed in C99 mode
     for (Py_ssize_t i = 0, l = asdl_seq_LEN(args->posonlyargs); i < l; i++) {
     ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:330:21: error: redefinition of ‘i’
     for (Py_ssize_t i = 0, l = asdl_seq_LEN(args->args); i < l; i++) {
                     ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:325:21: note: previous definition of ‘i’ was here
     for (Py_ssize_t i = 0, l = asdl_seq_LEN(args->posonlyargs); i < l; i++) {
                     ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:330:28: error: redefinition of ‘l’
     for (Py_ssize_t i = 0, l = asdl_seq_LEN(args->args); i < l; i++) {
                            ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:325:28: note: previous definition of ‘l’ was here
     for (Py_ssize_t i = 0, l = asdl_seq_LEN(args->posonlyargs); i < l; i++) {
                            ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:330:5: error: ‘for’ loop initial declarations are only allowed in C99 mode
     for (Py_ssize_t i = 0, l = asdl_seq_LEN(args->args); i < l; i++) {
     ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:339:21: error: redefinition of ‘i’
     for (Py_ssize_t i = 0, l = asdl_seq_LEN(args->kwonlyargs); i < l; i++) {
                     ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:330:21: note: previous definition of ‘i’ was here
     for (Py_ssize_t i = 0, l = asdl_seq_LEN(args->args); i < l; i++) {
                     ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:339:28: error: redefinition of ‘l’
     for (Py_ssize_t i = 0, l = asdl_seq_LEN(args->kwonlyargs); i < l; i++) {
                            ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:330:28: note: previous definition of ‘l’ was here
     for (Py_ssize_t i = 0, l = asdl_seq_LEN(args->args); i < l; i++) {
                            ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:339:5: error: ‘for’ loop initial declarations are only allowed in C99 mode
     for (Py_ssize_t i = 0, l = asdl_seq_LEN(args->kwonlyargs); i < l; i++) {
     ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c: In function ‘fstring_shift_children_locations’:
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:387:13: error: ‘for’ loop initial declarations are only allowed in C99 mode
             for (Py_ssize_t i = 0, l = asdl_seq_LEN(n->v.ListComp.generators); i < l; i++) {
             ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:394:29: error: redefinition of ‘i’
             for (Py_ssize_t i = 0, l = asdl_seq_LEN(n->v.SetComp.generators); i < l; i++) {
                             ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:387:29: note: previous definition of ‘i’ was here
             for (Py_ssize_t i = 0, l = asdl_seq_LEN(n->v.ListComp.generators); i < l; i++) {
                             ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:394:36: error: redefinition of ‘l’
             for (Py_ssize_t i = 0, l = asdl_seq_LEN(n->v.SetComp.generators); i < l; i++) {
                                    ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:387:36: note: previous definition of ‘l’ was here
             for (Py_ssize_t i = 0, l = asdl_seq_LEN(n->v.ListComp.generators); i < l; i++) {
                                    ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:394:13: error: ‘for’ loop initial declarations are only allowed in C99 mode
             for (Py_ssize_t i = 0, l = asdl_seq_LEN(n->v.SetComp.generators); i < l; i++) {
             ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:402:29: error: redefinition of ‘i’
             for (Py_ssize_t i = 0, l = asdl_seq_LEN(n->v.DictComp.generators); i < l; i++) {
                             ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:394:29: note: previous definition of ‘i’ was here
             for (Py_ssize_t i = 0, l = asdl_seq_LEN(n->v.SetComp.generators); i < l; i++) {
                             ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:402:36: error: redefinition of ‘l’
             for (Py_ssize_t i = 0, l = asdl_seq_LEN(n->v.DictComp.generators); i < l; i++) {
                                    ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:394:36: note: previous definition of ‘l’ was here
             for (Py_ssize_t i = 0, l = asdl_seq_LEN(n->v.SetComp.generators); i < l; i++) {
                                    ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:402:13: error: ‘for’ loop initial declarations are only allowed in C99 mode
             for (Py_ssize_t i = 0, l = asdl_seq_LEN(n->v.DictComp.generators); i < l; i++) {
             ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:409:29: error: redefinition of ‘i’
             for (Py_ssize_t i = 0, l = asdl_seq_LEN(n->v.GeneratorExp.generators); i < l; i++) {
                             ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:402:29: note: previous definition of ‘i’ was here
             for (Py_ssize_t i = 0, l = asdl_seq_LEN(n->v.DictComp.generators); i < l; i++) {
                             ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:409:36: error: redefinition of ‘l’
             for (Py_ssize_t i = 0, l = asdl_seq_LEN(n->v.GeneratorExp.generators); i < l; i++) {
                                    ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:402:36: note: previous definition of ‘l’ was here
             for (Py_ssize_t i = 0, l = asdl_seq_LEN(n->v.DictComp.generators); i < l; i++) {
                                    ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:409:13: error: ‘for’ loop initial declarations are only allowed in C99 mode
             for (Py_ssize_t i = 0, l = asdl_seq_LEN(n->v.GeneratorExp.generators); i < l; i++) {
             ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:430:29: error: redefinition of ‘i’
             for (Py_ssize_t i = 0, l = asdl_seq_LEN(n->v.Call.keywords); i < l; i++) {
                             ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:409:29: note: previous definition of ‘i’ was here
             for (Py_ssize_t i = 0, l = asdl_seq_LEN(n->v.GeneratorExp.generators); i < l; i++) {
                             ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:430:36: error: redefinition of ‘l’
             for (Py_ssize_t i = 0, l = asdl_seq_LEN(n->v.Call.keywords); i < l; i++) {
                                    ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:409:36: note: previous definition of ‘l’ was here
             for (Py_ssize_t i = 0, l = asdl_seq_LEN(n->v.GeneratorExp.generators); i < l; i++) {
                                    ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:430:13: error: ‘for’ loop initial declarations are only allowed in C99 mode
             for (Py_ssize_t i = 0, l = asdl_seq_LEN(n->v.Call.keywords); i < l; i++) {
             ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c: In function ‘fstring_fix_expr_location’:
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:521:13: error: ‘for’ loop initial declarations are only allowed in C99 mode
             for (char* p = parent_str; p < substr; p++) {
             ^
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pablogsal pablogsal mentioned this pull request Apr 22, 2020
bpo-40334: PEP 617: New PEG parser for CPython #19503
Merged
@pablogsal
pablogsal merged commit 458004b into python:master Apr 22, 2020
@bedevere-bot bedevere-bot removed the awaiting core review label Apr 22, 2020
@pablogsal
pablogsal deleted the fix_buildbot_errors branch April 22, 2020 23:13
@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 22, 2020
@bedevere-bot

bedevere-bot commented Apr 22, 2020

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 3192787 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@pablogsal pablogsal

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@pablogsal @bedevere-bot @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.