GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-32604: Add support for a "default" arg in channel_recv(). by ericsnowcurrently · Pull Request #19770 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Apr 28, 2020 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This allows the caller to avoid creation of an exception when the channel is empty (just like dict.get() works). ChannelEmptyError is still raised if no default is provided.

https://bugs.python.org/issue32604

Automerge-Triggered-By: @ericsnowcurrently

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ericsnowcurrently added 2 commits April 28, 2020 15:22
@ericsnowcurrently
Add support for a default arg in channel_recv().
b5edb12
@ericsnowcurrently
Do not exit _channel_recv() without freeing the cross-interpreter data.
2183afc
@ericsnowcurrently ericsnowcurrently added the skip news label Apr 28, 2020
@ericsnowcurrently
ericsnowcurrently requested a review from nanjekyejoannah April 28, 2020 21:31
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 28, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Apr 28, 2020
nanjekyejoannah
nanjekyejoannah approved these changes Apr 28, 2020
View reviewed changes

@nanjekyejoannah nanjekyejoannah left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Modules/_xxsubinterpretersmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Apr 28, 2020
@ericsnowcurrently
Fix a typo in a docstring.
4c2c7cc
@ericsnowcurrently ericsnowcurrently added the 🤖 automerge label Apr 28, 2020
@miss-islington

miss-islington commented Apr 28, 2020

Copy link
Copy Markdown
Contributor

@ericsnowcurrently: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit 5e8c691 into python:master Apr 28, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 28, 2020
@ericsnowcurrently
ericsnowcurrently deleted the channel-recv-default branch April 28, 2020 23:16
@ericsnowcurrently ericsnowcurrently mentioned this pull request Apr 10, 2022
[subinterpreters] PEP 554 implementation: add interpreters module #76785
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nanjekyejoannah nanjekyejoannah nanjekyejoannah approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@ericsnowcurrently @miss-islington @nanjekyejoannah @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.