GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40334: Disallow invalid single statements in the new parser by lysnikolaou · Pull Request #19774 · python/cpython

Conversation

@lysnikolaou

@lysnikolaou lysnikolaou commented Apr 28, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

After parsing is done, a single statement has to be checked for
additional lines and a SyntaxError must be raised, in case there
are any.

Closes we-like-parsers#99.

https://bugs.python.org/issue40334

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lysnikolaou
bpo-40334: Disallow invalid single statements in the new parser
fa9d708 
After parsing is done, a single statement has to be checked for
additional lines and a `SyntaxError` must be raised, in case there
are any.

Closes we-like-parsers#99.
@lysnikolaou
lysnikolaou requested a review from pablogsal as a code owner April 28, 2020 23:07
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 28, 2020
@bedevere-bot bedevere-bot added the awaiting review label Apr 28, 2020
@lysnikolaou
lysnikolaou requested a review from gvanrossum April 28, 2020 23:07
@lysnikolaou lysnikolaou added the skip news label Apr 28, 2020
@lysnikolaou
lysnikolaou marked this pull request as draft April 28, 2020 23:34
@lysnikolaou
Check if newline is allowed (preceded by linecont character or appear…
a9a60a7 
…s inside a string)
@lysnikolaou
lysnikolaou marked this pull request as ready for review April 29, 2020 00:16
pablogsal
pablogsal reviewed Apr 29, 2020
View reviewed changes
Comment thread Parser/pegen/pegen.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
pablogsal
pablogsal reviewed Apr 29, 2020
View reviewed changes
Comment thread Parser/pegen/pegen.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
pablogsal
pablogsal reviewed Apr 29, 2020
View reviewed changes
Comment thread Parser/pegen/pegen.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@lysnikolaou
PEP 7
4f11574
pablogsal
pablogsal reviewed Apr 29, 2020
View reviewed changes
Comment thread Parser/pegen/pegen.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@lysnikolaou @pablogsal
More PEP 7
6cbb27f 
Co-Authored-By: Pablo Galindo <[email protected]>
pablogsal
pablogsal reviewed Apr 29, 2020
View reviewed changes
Comment thread Parser/pegen/pegen.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@lysnikolaou
Add comment
baa16b8
pablogsal
pablogsal approved these changes Apr 29, 2020
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Apr 29, 2020
@pablogsal

pablogsal commented Apr 29, 2020

Copy link
Copy Markdown
Member

Nice work! One test less to go :)
lysnikolaou reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lysnikolaou

lysnikolaou commented Apr 29, 2020

Copy link
Copy Markdown
Member Author

One test less to go :)

Yup! We're slowly getting there!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
pablogsal merged commit 6d65087 into python:master Apr 29, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 29, 2020
@lysnikolaou
lysnikolaou deleted the invalid-single-statements branch April 29, 2020 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Multiline single statement is allowed

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@lysnikolaou @pablogsal @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.