GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-1635741: Port _stat module to multiphase initialization by corona10 · Pull Request #19798 · python/cpython

Conversation

@corona10

@corona10 corona10 commented Apr 29, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue1635741

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 29, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Apr 29, 2020
@corona10
bpo-1635741: Port _stat module to multiphase initialization
0d534df
@corona10
corona10 force-pushed the bpo-1635741-stat branch from 9142b06 to 0d534df Compare April 29, 2020 16:46
vstinner
vstinner reviewed Apr 29, 2020
View reviewed changes
Comment thread Modules/_stat.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@corona10
bpo-1635741: Apply code review
bd8dac7
@corona10
corona10 requested a review from vstinner April 29, 2020 17:23
@corona10

corona10 commented Apr 29, 2020

Copy link
Copy Markdown
Member Author

@vstinner Please take a look
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10
bpo-1635741: Fix
cb75a3a
vstinner
vstinner reviewed Apr 29, 2020
View reviewed changes
Comment thread Modules/_stat.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@corona10
bpo-1635741: Update
41fdd0f
vstinner
vstinner reviewed Apr 29, 2020
View reviewed changes
Comment thread Modules/_stat.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_stat.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_stat.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@corona10
bpo-1635741: Apply Victor's suggestion
bf0be2b
vstinner
vstinner approved these changes Apr 29, 2020
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the updates!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Apr 29, 2020
@corona10
corona10 merged commit 84724dd into python:master Apr 29, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 29, 2020
@corona10
corona10 deleted the bpo-1635741-stat branch April 29, 2020 18:20
@vstinner

vstinner commented Apr 30, 2020

Copy link
Copy Markdown
Member

The new code emits a compiler warning:

./Modules/_stat.c: In function ‘stat_exec’:
./Modules/_stat.c:566:23: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
     for (int i = 0; i < Py_ARRAY_LENGTH(st_constants); i++) {
                       ^

Py_ARRAY_LENGTH() should be casted to int.

cc @corona10
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Apr 30, 2020

Copy link
Copy Markdown
Member

Py_ARRAY_LENGTH() should be casted to int.

After I saw the warning 5 times in a row, I decided to propose a PR for the trivial fix :-)
#19822
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Py_Finalize() doesn't clear all Python objects at exit #44470
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@corona10 @vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.